Created attachment 13275 [details] [review] Bug 9012 - --framework option for bulkmarcimport This allows the --framework option to be specified when running bulkmarkimport. This option allows a framework code to be specified for the records being imported.
Created attachment 13351 [details] [review] [SIGNED-OFF] Bug 9012 - --framework option for bulkmarcimport This allows the --framework option to be specified when running bulkmarkimport. This option allows a framework code to be specified for the records being imported. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Perlcritic failing before and after applying the patch, noting results here: "require" statement with library name as string at line 11, column 12. Use a bareword instead. (Severity: 5) Bareword file handle opened at line 74, column 3. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 74, column 3. See page 207 of PBP. (Severity: 5) Variable declared in conditional statement at line 439, column 9. Declare variables outside of the condition. (Severity: 5) But patch works nicely, passing QA.
Created attachment 13824 [details] [review] [SIGNED-OFF] Bug 9012 - --framework option for bulkmarcimport This allows the --framework option to be specified when running bulkmarkimport. This option allows a framework code to be specified for the records being imported. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, perlcritic fails before and after. Tested - imported records with -framework FA, FA framework is used - imported records without -framework, default framework is used
This patch has been pushed to master.