Summary: | Hourly fines does not work in koha 3.8.6 | ||
---|---|---|---|
Product: | Koha | Reporter: | Humberto Blanco <hblancoca> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED DUPLICATE | QA Contact: | |
Severity: | critical | ||
Priority: | P1 - high | CC: | gmcharlt, kyle.m.hall, kyle |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8966 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Humberto Blanco
2012-11-08 22:48:29 UTC
Review the source code i found that in Koha::Calendar.pm, in the sub addDate when evaluate $self->is_holiday($dt) the results for $dt appears bad, then in the Circulation.pm returns INVALID_DATE and needs manually checkout. For my biblio, i assume that all loans not in holidays then i put this in Koha::Calendar.pm if ( $days_mode eq 'Datedue' ){ my $dt = $base_date + $add_duration; if($unit ne 'hours'){ # Added for me while ( $self->is_holiday($dt) ) { $dt->add_duration($day_dur); if ( $unit eq 'hours' ) { $dt->set_hour($return_by_hour); # Staffs specific } } } # End added for me return $dt; } |