Summary: | When ordering from staged file '# Bibs' is empty | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7180 | ||
Bug Blocks: | |||
Attachments: |
screenshot
Bug 9063: When ordering from staged file '# Bibs' is empty [SIGNED-OFF] Bug 9063: When ordering from staged file '# Bibs' is empty [PASSED QA] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 9063: When ordering from staged file '# Bibs' is empty |
This is still an issue on current master. I think this problem is caused by renaming the database column from num_biblios to num_records when authority importing/matching was introduced. Created attachment 27132 [details] [review] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Patch created on top of bug 7180. Feel free to provide a patch based on master. Created attachment 27264 [details] [review] [SIGNED-OFF] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 27326 [details] [review] [PASSED QA] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. This patch does not apply. Since the dependency on 7180 is only textual, if Jonathan wants to rebase this one and put it back to passed QA after doing so, that's fine with me. I happened to fix this bug already via one of my follow-ups for bug 7180. Sorry for forgetting about this one. Created attachment 27957 [details] [review] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. (In reply to Galen Charlton from comment #8) > I happened to fix this bug already via one of my follow-ups for bug 7180. > Sorry for forgetting about this one. Maybe this patch is still useful since it changes the variable name in the tt file too. Pushed to master. Thanks, Jonathan! |
Created attachment 13409 [details] screenshot When ordering from a staged file in acquisitions, the column '# Bibs' in the table is empty for my staged file with 17 records.