Summary: | Download option from the cart should match the menu button in lists | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jcamins, kyle, liz |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25402 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9073 - Download option from the cart should match the menu button in lists
Bug 9073 - Download option from the cart should match the menu button in lists [SIGNED-OFF] Bug 9073 - Download option from the cart should match the menu button in lists |
Description
Owen Leonard
2012-11-14 13:39:47 UTC
Created attachment 13568 [details] [review] Bug 9073 - Download option from the cart should match the menu button in lists This patch moves the staff client Cart download choices into a toolbar menu button instead of requiring that the user make the choice via a form in the pop-up window. To test, add items to Cart in the staff client. Open the cart and choose a download option from the Download menu. Your download should complete correctly without the page changing or reloading. Unrelated edit: Eliminating duplicate document.ready() block by consolidating a couple of lines of JavaScript. Created attachment 13577 [details] [review] Bug 9073 - Download option from the cart should match the menu button in lists This patch moves the staff client Cart download choices into a toolbar menu button instead of requiring that the user make the choice via a form in the pop-up window. To test, add items to Cart in the staff client. Open the cart and choose a download option from the Download menu. Your download should complete correctly without the page changing or reloading. Unrelated edit: Eliminating duplicate document.ready() block by consolidating a couple of lines of JavaScript. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 13661 [details] [review] [SIGNED-OFF] Bug 9073 - Download option from the cart should match the menu button in lists This patch moves the staff client Cart download choices into a toolbar menu button instead of requiring that the user make the choice via a form in the pop-up window. To test, add items to Cart in the staff client. Open the cart and choose a download option from the Download menu. Your download should complete correctly without the page changing or reloading. Unrelated edit: Eliminating duplicate document.ready() block by consolidating a couple of lines of JavaScript. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked all export formats can be selected and downloaded, including CSV profiles. All tests and perlcritic pass. Hi Owen, I think this would be a nice change for the OPAC cart interface too. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.1 Pushed to 3.8.x will be in 3.8.8 Pushed to 3.6.x will be in 3.6.11. |