Summary: | non translatable string in manage-marc-import | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 10170 | ||
Attachments: |
untranslatable string
Bug 9215 - non translatable string in manage-marc-import Bug 9215 - non translatable string in manage-marc-import Bug 9215 - non translatable string in manage-marc-import |
Created attachment 14342 [details] [review] Bug 9215 - non translatable string in manage-marc-import Status information about staged MARC record batches was being pulled directly from the import_batches table where they are stored as English strings. This patch puts a check on the status value into the template so that translatable strings can be embedded. To test, apply the patch and view both the table of staged MARC record batches and details about individual batches. In the default 'en' translation you should see import statuses displayed with a capital letter ("Staged"). This indicates that the status is now being pulled from the template. Created attachment 14380 [details] [review] Bug 9215 - non translatable string in manage-marc-import Status information about staged MARC record batches was being pulled directly from the import_batches table where they are stored as English strings. This patch puts a check on the status value into the template so that translatable strings can be embedded. To test, apply the patch and view both the table of staged MARC record batches and details about individual batches. In the default 'en' translation you should see import statuses displayed with a capital letter ("Staged"). This indicates that the status is now being pulled from the template. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA Comment: Works as expected: the strings are now translatable (msgid "" "%s Cleaned %s Imported %s Importing %s Reverted %s Reverting %s Staged %s %s " "%s ") Marked as Passed QA. Created attachment 14566 [details] [review] Bug 9215 - non translatable string in manage-marc-import Status information about staged MARC record batches was being pulled directly from the import_batches table where they are stored as English strings. This patch puts a check on the status value into the template so that translatable strings can be embedded. To test, apply the patch and view both the table of staged MARC record batches and details about individual batches. In the default 'en' translation you should see import statuses displayed with a capital letter ("Staged"). This indicates that the status is now being pulled from the template. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.2 Does not apply to 3.8.x please create a 3.8.x patch if you want this to be in 3.8.x also |
Created attachment 13892 [details] untranslatable string There is a non translatable string in manage-marc-import (see screenshot)