Bug 9215 - non translatable string in manage-marc-import
Summary: non translatable string in manage-marc-import
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 10170
  Show dependency treegraph
 
Reported: 2012-12-05 09:57 UTC by Paul Poulain
Modified: 2013-12-05 20:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
untranslatable string (31.35 KB, image/jpeg)
2012-12-05 09:57 UTC, Paul Poulain
Details
Bug 9215 - non translatable string in manage-marc-import (3.68 KB, patch)
2012-12-31 16:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9215 - non translatable string in manage-marc-import (3.70 KB, patch)
2013-01-02 22:18 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9215 - non translatable string in manage-marc-import (3.76 KB, patch)
2013-01-14 16:03 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2012-12-05 09:57:04 UTC
Created attachment 13892 [details]
untranslatable string

There is a non translatable string in manage-marc-import (see screenshot)
Comment 1 Owen Leonard 2012-12-31 16:52:33 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-01-02 22:18:11 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-01-14 16:03:31 UTC
QA Comment:

Works as expected: the strings are now translatable (msgid ""
"%s Cleaned %s Imported %s Importing %s Reverted %s Reverting %s Staged %s %s "
"%s ")

Marked as Passed QA.
Comment 4 Jonathan Druart 2013-01-14 16:03:55 UTC
Created attachment 14566 [details] [review]
Bug 9215 - non translatable string in manage-marc-import

Status information about staged MARC record batches was being pulled
directly from the import_batches table where they are stored as English
strings. This patch puts a check on the status value into the template
so that translatable strings can be embedded.

To test, apply the patch and view both the table of staged MARC record
batches and details about individual batches. In the default 'en'
translation you should see import statuses displayed with a capital
letter ("Staged"). This indicates that the status is now being pulled
from the template.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2013-01-15 04:28:24 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2013-01-15 05:12:23 UTC
Pushed to 3.10.x will be in 3.10.2

Does not apply to 3.8.x please create a 3.8.x patch if you want this to be in 3.8.x also