Summary: | Switch to HTML5 doctype in OPAC and staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | mirko, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9265 - Switch to HTML5 doctype in OPAC and staff client
Bug 9265 - Switch to HTML5 doctype in OPAC and staff client Bug 9265 - Switch to HTML5 doctype in OPAC and staff client Bug 9265 - Switch to HTML5 doctype in OPAC and staff client |
Description
Owen Leonard
2012-12-11 17:32:51 UTC
+1 Created attachment 14052 [details] [review] Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Created attachment 14078 [details] [review] Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype Created attachment 14925 [details] [review] Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype Created attachment 14926 [details] [review] Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype Signed-off-by: Mason James <mtj@kohaaloha.com> (In reply to comment #5) > Created attachment 14926 [details] [review] > Bug 9265 - Switch to HTML5 doctype in OPAC and staff client > > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > test on some intranet pages and I found no regression. (chromium and > firefox). > The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype > > Signed-off-by: Mason James <mtj@kohaaloha.com> passing QA on this patch tested on firefox, chrome, opera, and safari browers - with no regressions This patch has been pushed to master. One validation error I noticed on a lot of pages in the OPAC was "Line 454, Column 47: Element script must not have attribute charset unless attribute src is also specified." (the line and column number changed, of course) However, I think this is still a good patch to get in right away. |