| Summary: | Untranslated strings in tags moderation | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | I18N/L10N | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, gmcharlt, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Error while rejecting tag in translated staff client (German)
Bug 9266 - Untranslated strings in tags moderation Signed off patch Bug 9266 - Untranslated strings in tags moderation |
||
Tested in 3.10.1. I can reproduce the problem using the checkboxes and the buttons below the list of tags. Also I noted some other translation related problems: 1) On the OPAC detail page there is a little icon in front of 'Add' that is missing in the German templates before 'Hinzufügen'. 2) When you use the 'reject' and 'accept' links in the list of terms, after rejecting or accepting one of the buttons appears in English. Looking like: Bestätigt (= Accepted) | Reject Approve | Abgelehnt (= Rejected) Since the patch for Bug 10022 fixes the original problem described in this bug I'm having Katrin's #2 problem above take over this report: > 2) When you use the 'reject' and 'accept' links in the list of terms, after > rejecting or accepting one of the buttons appears in English. I could not reproduce this problem: > 1) On the OPAC detail page there is a little icon in front of 'Add' that is > missing in the German templates before 'Hinzufügen'. Created attachment 17730 [details] [review] Bug 9266 - Untranslated strings in tags moderation There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. Created attachment 17761 [details] [review] Signed off patch Created attachment 17778 [details] [review] Bug 9266 - Untranslated strings in tags moderation There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mason James <mtj@kohaaloha.com> > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
> Signed-off-by: Mason James <mtj@kohaaloha.com>
QA-comment: tested ok, passing QA
This patch has been pushed to master and 3.12.x. Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 |
Created attachment 14013 [details] Error while rejecting tag in translated staff client (German) Rejecting tags results in message: Unbekannte Operation (ablehnen) mit 2 Begriff(en). Steps to reproduce: 1) Go to Home › Tools › Tags 2) Filter tags to show a list of tags. Check checkboxes of tags you want to reject. Click "Reject" at the bottom Result in English staff client: "Rejected 1 Term(s). " Result in German Staff client: "Unbekannte Operation (ablehnen) mit 1 Begriff(en)." (Unknown operation (ablehnen)...) Same with approve. I tested on a 3.9 demo server, German translation installed. Can somebody confirm for newer version and for other languages?