Bug 10022 - Multiple tags moderation doesn't work on translated page
Summary: Multiple tags moderation doesn't work on translated page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-10 10:36 UTC by Fridolin Somers
Modified: 2013-12-05 20:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.92 KB, patch)
2013-04-10 12:11 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10022 - Multiple tags moderation doesn't work on translated page (3.02 KB, patch)
2013-04-26 17:56 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 10022 - Multiple tags moderation doesn't work on translated page (3.06 KB, patch)
2013-04-29 05:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-04-10 10:36:47 UTC
When using a translated intranet, tags moderation using checkboxes and a submit button doesn't work.
You get a message "Unknown Operation on x Term(s)" (translated of course).

This is because submit value is translated, it must not be used in perl page to find witch submit button has been pushed.
Comment 1 Fridolin Somers 2013-04-10 12:11:03 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-04-10 13:59:38 UTC
Hi Fridolyn, I also ran into translation related problems with tags some time ago. Maybe take a look at 9266 if it is a duplicate?
Comment 3 Chris Cormack 2013-04-19 22:56:25 UTC
This does look similar to bug 9266, whoever signs off code test both, and mark 9266 resolved duplicate if this solves both
Comment 4 Owen Leonard 2013-04-26 17:56:11 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-04-29 05:44:32 UTC
Created attachment 17780 [details] [review]
[PASSED QA] Bug 10022 - Multiple tags moderation doesn't work on translated page

When using a translated intranet, tags moderation using checkboxes and a
submit button doesn't work. You get a message "Unknown Operation on x
Term(s)" (translated of course).

This patch corrects by using name="op-[operation]" instead of name="op"
in each submit input.

Test plan :
- Create a new tag on a record
- Go to tags moderation in Tools
=> You should see your tag in pending terms
- Click on checkbox
- Click on Approve or Reject submit button at the bottom of the table
=> Without patch the tag is still pending
=> With patch operation is well performed, tag is not pending
- Test "Check lists" form
- Test Approve and Reject buttons from "Actions" column

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Comment 6 Jared Camins-Esakov 2013-05-01 10:44:44 UTC
This patch has been pushed to master and 3.12.x.
Comment 7 Chris Cormack 2013-05-08 07:54:55 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13