| Summary: | Remove dead code related to 'publictype' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 9292 - Remove dead code related to 'publictype'
Bug 9292 - Remove dead code related to 'publictype' Bug 9292 - Remove dead code related to 'publictype' Bug 9292 - Remove dead code related to 'publictype' |
||
|
Description
Kyle M Hall (khall)
2012-12-14 19:43:18 UTC
Created attachment 14153 [details] [review] Bug 9292 - Remove dead code related to 'publictype' This patch should have a commit message which includes a description of the problem, a description of the solution, and a test plan. Created attachment 14366 [details] [review] Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior Created attachment 14484 [details] [review] Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior Signed-off-by: Galen Charlton <gmc@esilibrary.com> QA Comment: I did not find any occurrence of publictype. These lines are useless and can be deleted. Marked as Passed QA. Created attachment 14497 [details] [review] Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x, will be in 3.10.2 and 3.8.9 |