| Summary: | Untranslatable strings in ajax.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, f.demians, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9331 - Untranslatable strings in ajax.js
Bug 9331 - Untranslatable strings in ajax.js Bug 9331 - Untranslatable strings in ajax.js |
||
Created attachment 14341 [details] [review] Bug 9331 - Untranslatable strings in ajax.js This patch moves untranslatable strings from ajax.js into the template where they can be picked up by the translation script. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Failed to mention in my commit message: I also made a couple of trivial JSHint-recommended corrections. Created attachment 14349 [details] [review] Bug 9331 - Untranslatable strings in ajax.js This patch moves untranslatable strings from ajax.js into the template where they can be picked up by the translation script. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still works, and is now translatable QA Comments: Strings are now translatable. Moreover this patch fixes 2 JS equality and some semi-colons. Marking as Passed QA. Created attachment 14421 [details] [review] Bug 9331 - Untranslatable strings in ajax.js This patch moves untranslatable strings from ajax.js into the template where they can be picked up by the translation script. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still works, and is now translatable Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |
ajax.js contains several English strings which, although they are optimistically wrapped in _(' '), will not be picked up by the translation script. These strings must be moved to the relevant templates.