Bug 9331 - Untranslatable strings in ajax.js
Summary: Untranslatable strings in ajax.js
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-31 13:50 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9331 - Untranslatable strings in ajax.js (5.68 KB, patch)
2012-12-31 16:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9331 - Untranslatable strings in ajax.js (5.74 KB, patch)
2013-01-01 18:05 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9331 - Untranslatable strings in ajax.js (5.80 KB, patch)
2013-01-04 15:39 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-12-31 13:50:30 UTC
ajax.js contains several English strings which, although they are optimistically wrapped in _(' '), will not be picked up by the translation script. These strings must be moved to the relevant templates.
Comment 1 Owen Leonard 2012-12-31 16:16:11 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-12-31 16:19:41 UTC
Failed to mention in my commit message: I also made a couple of trivial JSHint-recommended corrections.
Comment 3 Chris Cormack 2013-01-01 18:05:17 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-01-04 15:38:39 UTC
QA Comments:

Strings are now translatable.
Moreover this patch fixes 2 JS equality and some semi-colons.

Marking as Passed QA.
Comment 5 Jonathan Druart 2013-01-04 15:39:13 UTC
Created attachment 14421 [details] [review]
Bug 9331 - Untranslatable strings in ajax.js

This patch moves untranslatable strings from ajax.js into the template
where they can be picked up by the translation script.

To test that preference-related error messages continue to work,
open the system preferences editor in two tabs. Log out in one tab and
try to save a system preference in the other. You should see correct
error messages.

To test that error strings are now translatable, run "perl translate update
 <lang>" from misc/translator, then check if the affected strings shows
up in the po file.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Still works, and is now translatable

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jared Camins-Esakov 2013-01-08 01:35:42 UTC
This patch has been pushed to master.