Description
Galen Charlton
2013-01-07 16:19:00 UTC
Created attachment 14455 [details] [review] Bug 9358 - Fixed field plugins for MARC21 should be updated for MARC21 update #15 This patch, together with 9357, fix plugins for leader, 006, 007 and 008 MARC21 fields Leader18 c and i is fixed on Bug 9357 Added missing/renamed fields on 007 Options 'o' and 'q' already present on 006 and 008, fixing spaces and removing unnecessary descriptions. To test: 1) Catalog/edit a record 2) On 007 value builder, check missing values on 008, BKS, check for example 33- Literary form, i- Letters has a description 3) Apply the patch 4) Clean your browser cache 5) On 007 value builder, new values are present On 008/6 descriptions are absent Created attachment 14485 [details] [review] Bug 9358 - Fixed field plugins for MARC21 should be updated for MARC21 update #15 This patch, together with 9357, fix plugins for leader, 006, 007 and 008 MARC21 fields Leader18 c and i is fixed on Bug 9357 Added missing/renamed fields on 007 Options 'o' and 'q' already present on 006 and 008, fixing spaces and removing unnecessary descriptions. To test: 1) Catalog/edit a record 2) On 007 value builder, check missing values on 008, BKS, check for example 33- Literary form, i- Letters has a description 3) Apply the patch 4) Clean your browser cache 5) On 007 value builder, new values are present On 008/6 descriptions are absent Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 16369 [details] [review] [PASSED QA] Bug 9358 - Fixed field plugins for MARC21 should be updated for MARC21 update #15 This patch, together with 9357, fix plugins for leader, 006, 007 and 008 MARC21 fields Leader18 c and i is fixed on Bug 9357 Added missing/renamed fields on 007 Options 'o' and 'q' already present on 006 and 008, fixing spaces and removing unnecessary descriptions. To test: 1) Catalog/edit a record 2) On 007 value builder, check missing values on 008, BKS, check for example 33- Literary form, i- Letters has a description 3) Apply the patch 4) Clean your browser cache 5) On 007 value builder, new values are present On 008/6 descriptions are absent Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. I would be willing to push this as a partial fix, but it does not update all the fixed field plugins for MARC21 update #5. 008/20 for music should have an additional value 'k' for vocal scores (and there may be other gaps). However, I'm setting this to "In Discussion" for now, pending feedback from Bernardo about whether he wants to do a follow-up before I push it, or open another bug for the last missing values. (In reply to comment #4) > I would be willing to push this as a partial fix, but it does not update all > the fixed field plugins for MARC21 update #5. 008/20 for music should have > an additional value 'k' for vocal scores (and there may be other gaps). > However, I'm setting this to "In Discussion" for now, pending feedback from > Bernardo about whether he wants to do a follow-up before I push it, or open > another bug for the last missing values. I'll do a follow-up. Better to fix it now. Created attachment 16919 [details] [review] Bug 9358 - Followup - Fixed field plugins for MARC21 should be updated for MARC21 update #15 This little patch adds a few values and descriptions to complete value builder for marc21 008. Switch to Needs Signof. Small followup. Created attachment 17223 [details] [review] Bug 9358 - Followup - Fixed field plugins for MARC21 should be updated for MARC21 update #15 This little patch adds a few values and descriptions to complete value builder for marc21 008. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17605 [details] [review] [PASSED QA] Bug 9358 - Followup - Fixed field plugins for MARC21 should be updated for MARC21 update #15 This little patch adds a few values and descriptions to complete value builder for marc21 008. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Follow-up works as described. XML change only. This patch has been pushed to master and 3.12.x. Thanks for filling in the gaps. Well, right now I have mixed feelings about this :-) I'm working on a yet unnamed patch to change the structure of these files (xml for 006 and 008). The purpose is move attributes to elements, so to make these files translatable. In that way standard tools could be used to extract all strings. I'll report (in other bug) when done. Hi Bernardo, I would really love to see that long standing bug fixed. *** Bug 10109 has been marked as a duplicate of this bug. *** Pushed to 3.10.x will be in 3.10.6 Both patches have been pushed to 3.8.x, will be in 3.8.14 |