Summary: | Bold necessary permissions for staff client access. | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <liz> |
Component: | Staff interface | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, derrynj, egpetridis, elliott, gmcharlt, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9382 - updating permission labels
Bug 9382 - updating permission labels [SIGNED-OFF] Bug 9382 - updating permission labels Bug 9382 - updating permission labels |
Description
Liz Rea
2013-01-13 21:06:14 UTC
Created attachment 14760 [details] [review] Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. I see a few differences between the start-from-scratch database and the updated-existing database versions: Flag 2, "catalogue": New db: "Staff access, allows viewing of catalogue in staff client.)" Updated db: Staff access, allows viewing of catalogue in staff client." (^^ extra ')' in new db) Flag 3, "parameters": New db: "Set Koha system parameters." Updated db: "Manage Koha system settings (Administration panel)" Flag 12, "management": New db: "Manage Koha system settings (Administration panel)" Updated db: "Set library management parameters (deprecated)" And by the way, unrelated to this patch: tools:edit_patrons New db: "Perform batch modification of patrons" Updated db: "Perform batch modifivation of patrons" Ah thanks - will fix those things. :) Created attachment 14762 [details] [review] Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - edit_patrons (only on updatedb, not on new db) - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. Created attachment 14902 [details] [review] [SIGNED-OFF] Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - edit_patrons (only on updatedb, not on new db) - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested both with existing database and new database Created attachment 14911 [details] [review] Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - edit_patrons (only on updatedb, not on new db) - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested both with existing database and new database Signed-off-by: Elliott Davis <elliott@bywatersolions.com> Tested with existing database. Introduces no new mysql-isms. Kudos for adding that syspref in bold, that got me when I first started with Koha This patch has been pushed to master. There are still capitalization issues in the permissions, but the screen is much better with this patch. Pushed to 3.10.x will be in 3.10.3 Um, hate to point it out - but this untranslates existing translated permissions for non-English installations... could we add a condition here please? Apart from that I think staffaccess does not do what the description says, as that is what permissions does: INSERT INTO `userflags` VALUES(5,'permissions','Set user permissions',0); +INSERT INTO `userflags` VALUES(17,'staffaccess','Allow staff members to modify permissions for other staff members',0); From looking at the code and from what we experienced with one of our libraries I think the permission is actually about changing other staff account details (like passwords, usernames, etc.) (In reply to comment #9) > Um, hate to point it out - but this untranslates existing translated > permissions for non-English installations... could we add a condition here > please? Sorry Katrin, not sure what you mean here? What kind of condition? For example we could check for English strings in the permissions description - so German and other translated permissions would not be harmed by this patch. To be more clear - I am talking about the updatedatabase.pl part of this patch :) Bug should not be reopened because it's already been pushed, so I think another patch has to go on a new bug? Should I file one? When I updated from 3.10.00 to 3.10.03 the web installer throws this: updatedatabase.pl: Undefined subroutine &main::CheckVersion called at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 6092. That particular line was added by this patch: if ( CheckVersion($DBversion) ) { Upon further investigation, there is indeed no 'CheckVersion' subroutine that I could find. Fixed and new tarball pushed, thanks for the catch. Could this "CheckVersion" error have crept into v3.08.11 as well? If so, please check bug #9962 for details. |