| Summary: | confirmation does not appear for negative notforloan items issues | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Cataloging | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed patch
Bug 9392: confirmation does not appear for negative notforloan items issues [SIGNED-OFF] Bug 9392: confirmation does not appear for negative notforloan items issues |
||
|
Description
Fridolin Somers
2013-01-15 08:22:21 UTC
Created attachment 14590 [details] [review] Proposed patch See commit message. Created attachment 14615 [details] [review] Bug 9392: confirmation does not appear for negative notforloan items issues When checking-out an item marked "not for loan" with a positive value, you get a message to forbid or confirm issue (depending on AllowNotForLoanOverride syspref). For an item with a negative value (usually during acquisition process), the issue is made without forbid or confirm message. This patch simply changes the test notforloan > 0 into notforloan != 0. Test plan : - Checkout an item with items.notforloan = 0 => The item is issued without message - Checkout an item with items.notforloan > 0 => A message forbids or asks confirmation to override - Checkout an item with items.notforloan < 0 (e.g., on order) => A message forbids or asks confirmation to override Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 15189 [details] [review] [SIGNED-OFF] Bug 9392: confirmation does not appear for negative notforloan items issues When checking-out an item marked "not for loan" with a positive value, you get a message to forbid or confirm issue (depending on AllowNotForLoanOverride syspref). For an item with a negative value (usually during acquisition process), the issue is made without forbid or confirm message. This patch simply changes the test notforloan > 0 into notforloan != 0. Test plan : - Checkout an item with items.notforloan = 0 => The item is issued without message - Checkout an item with items.notforloan > 0 => A message forbids or asks confirmation to override - Checkout an item with items.notforloan < 0 (e.g., on order) => A message forbids or asks confirmation to override Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked with AllowNotForLoanOverride on and off. All tests and QA script pass. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.6 |