Description
Kyle M Hall (khall)
2013-01-15 12:22:31 UTC
Created attachment 14594 [details] [review] [SIGNED-OFF] Bug 9393 - Change 'mobile phone' to 'other phone', run typed in captcha through uc before comparing. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Label changed and captcha is not case sensitive Created attachment 14595 [details] [review] [SIGNED-OFF] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> New link "patron modifications" (if there are) on the checkout page. QA Comment: Small changes. Look good with two notes: members/members-update.pl still lists: Primary Mobile Phone (wrong case use too) I am wondering if we can do the other phone change like this. Lots of people may have entered mobile phone numbers here, and suddenly it is just an other phone. Could be that it should move to primary phone if that is not filled or so? We probably need more community consensus for such a change. Could you raise or prove that consensus? (In reply to M. de Rooy from comment #3) > > I am wondering if we can do the other phone change like this. Lots of people > may have entered mobile phone numbers here, and suddenly it is just an other > phone. The staff client already uses the "other phone" label. This patch simply makes the two interfaces consistent. The other issue (with members-update.pl) seems like it could be handled in a separate patch and shouldn't block this one in my opinion. Maybe we should change all the labels to read other/mobile phone. Created attachment 28913 [details] [review] Bug 9393: Capitalization fixes Call No. > Call no. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> I think it would be better if the OPAC-related changes could be split into their own bugs. Created attachment 50328 [details] [review] Bug 9393 - Change 'mobile phone' to 'other phone', run typed in captcha through uc before comparing. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Label changed and captcha is not case sensitive Created attachment 50329 [details] [review] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> New link "patron modifications" (if there are) on the checkout page. Created attachment 50335 [details] [review] Bug 9393 [QA Followup] - Change calls of Koha::Borrower::Modifications to Koha::Patron::Modifications Created attachment 50339 [details] [review] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> New link "patron modifications" (if there are) on the checkout page. (In reply to Owen Leonard from comment #7) > I think it would be better if the OPAC-related changes could be split into > their own bugs. Moved to bug 16283. Created attachment 50384 [details] [review] [PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> New link "patron modifications" (if there are) on the checkout page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Not a blocker, but a thing that could be improved: The link to "View all pending patron modifications" brings you to the modifications page - it would be nice if the patron you came from would be uncollapsed ready for you to edit. But something else: You might also not be able to see the entry for the patron because of IndependentBranchesPatronModifications - not sure how to handle this. Maybe we should only show the link of logged in branch and staff branch match? Sorry... maybe not the best morning for QA (first passing then putting back to Failed...) - but could you take another look? (In reply to Katrin Fischer from comment #14) > Not a blocker, but a thing that could be improved: The link to "View all > pending patron modifications" brings you to the modifications page - it > would be nice if the patron you came from would be uncollapsed ready for you > to edit. This does not appear to be possible with the accordion widget we are using. The pane can only be opened by index, and we cannot know the index based on the borrowernumber. If this is a blocker, please set the status of the bug to resolved, wontfix. Created attachment 50397 [details] [review] Bug 9393 [QA Followup] - Don't display link if librarian cannot view the modification Created attachment 50451 [details] [review] [PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> New link "patron modifications" (if there are) on the checkout page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 50452 [details] [review] [PASSED QA] Bug 9393 [QA Followup] - Don't display link if librarian cannot view the modification Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the May 2016 release! Patch pushed to 3.22.x, will be in 3.22.7 |