Bug 9393 - Add note to circulation.pl if borrower has pending modifications
Summary: Add note to circulation.pl if borrower has pending modifications
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 12:22 UTC by Kyle M Hall
Modified: 2016-12-05 21:25 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[SIGNED-OFF] Bug 9393 - Change 'mobile phone' to 'other phone', run typed in captcha through uc before comparing. (1.95 KB, patch)
2013-01-15 12:31 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9393 - Add note to circulation.pl if borrower has pending modifications (2.67 KB, patch)
2013-01-15 12:31 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9393: Capitalization fixes (2.04 KB, patch)
2014-06-17 16:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9393 - Change 'mobile phone' to 'other phone', run typed in captcha through uc before comparing. (953 bytes, patch)
2016-04-18 14:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9393 - Add note to circulation.pl if borrower has pending modifications (2.66 KB, patch)
2016-04-18 14:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9393 [QA Followup] - Change calls of Koha::Borrower::Modifications to Koha::Patron::Modifications (2.19 KB, patch)
2016-04-18 15:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9393 - Add note to circulation.pl if borrower has pending modifications (2.64 KB, patch)
2016-04-18 15:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending modifications (2.71 KB, patch)
2016-04-19 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 9393 [QA Followup] - Don't display link if librarian cannot view the modification (1.30 KB, patch)
2016-04-19 11:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending modifications (2.77 KB, patch)
2016-04-20 05:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 9393 [QA Followup] - Don't display link if librarian cannot view the modification (1.37 KB, patch)
2016-04-20 05:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-01-15 12:22:31 UTC
* Change 'mobile phone' to 'other phone'
* Run typed in captcha through uc before comparing.
* Add note to circulation.pl if borrower has pending modifications
Comment 1 Kyle M Hall 2013-01-15 12:31:15 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-01-15 12:31:31 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-03-01 11:18:49 UTC
QA Comment:
Small changes. Look good with two notes:

members/members-update.pl still lists: Primary Mobile Phone (wrong case use too)

I am wondering if we can do the other phone change like this. Lots of people may have entered mobile phone numbers here, and suddenly it is just an other phone.
Could be that it should move to primary phone if that is not filled or so?
We probably need more community consensus for such a change. Could you raise or prove that consensus?
Comment 4 Owen Leonard 2013-08-02 20:20:55 UTC
(In reply to M. de Rooy from comment #3)
> 
> I am wondering if we can do the other phone change like this. Lots of people
> may have entered mobile phone numbers here, and suddenly it is just an other
> phone.

The staff client already uses the "other phone" label. This patch simply makes the two interfaces consistent.

The other issue (with members-update.pl) seems like it could be handled in a separate patch and shouldn't block this one in my opinion.
Comment 5 Kyle M Hall 2013-12-13 18:31:27 UTC
Maybe we should change all the labels to read other/mobile phone.
Comment 6 Kyle M Hall 2014-06-17 16:34:57 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2016-04-06 14:14:12 UTC
I think it would be better if the OPAC-related changes could be split into their own bugs.
Comment 8 Kyle M Hall 2016-04-18 14:57:09 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2016-04-18 14:57:16 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2016-04-18 15:04:06 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall 2016-04-18 15:06:46 UTC Comment hidden (obsolete)
Comment 12 Kyle M Hall 2016-04-18 15:16:48 UTC
(In reply to Owen Leonard from comment #7)
> I think it would be better if the OPAC-related changes could be split into
> their own bugs.

Moved to bug 16283.
Comment 13 Katrin Fischer 2016-04-19 06:08:42 UTC Comment hidden (obsolete)
Comment 14 Katrin Fischer 2016-04-19 06:13:46 UTC
Not a blocker, but a thing that could be improved: The link to "View all pending patron modifications" brings you to the modifications page - it would be nice if the patron you came from would be uncollapsed ready for you to edit.

But something else: You might also not be able to see the entry for the patron because of IndependentBranchesPatronModifications - not sure how to handle this. Maybe we should only show the link of logged in branch and staff branch match?

Sorry... maybe not the best morning for QA (first passing then putting back to Failed...) - but could you take another look?
Comment 15 Kyle M Hall 2016-04-19 10:20:26 UTC
(In reply to Katrin Fischer from comment #14)
> Not a blocker, but a thing that could be improved: The link to "View all
> pending patron modifications" brings you to the modifications page - it
> would be nice if the patron you came from would be uncollapsed ready for you
> to edit.

This does not appear to be possible with the accordion widget we are using. The pane can only be opened by index, and we cannot know the index based on the borrowernumber.

If this is a blocker, please set the status of the bug to resolved, wontfix.
Comment 16 Kyle M Hall 2016-04-19 11:55:58 UTC Comment hidden (obsolete)
Comment 17 Katrin Fischer 2016-04-20 05:34:37 UTC
Created attachment 50451 [details] [review]
[PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending modifications

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
New link "patron modifications" (if there are) on the checkout page.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 18 Katrin Fischer 2016-04-20 05:35:08 UTC
Created attachment 50452 [details] [review]
[PASSED QA] Bug 9393 [QA Followup] - Don't display link if librarian cannot view the modification

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 19 Kyle M Hall 2016-04-29 11:53:42 UTC
Pushed to master for the May 2016 release!
Comment 20 Julian Maurice 2016-05-16 09:58:42 UTC
Patch pushed to 3.22.x, will be in 3.22.7