Summary: | add optional_params to C4::Service | ||
---|---|---|---|
Product: | Koha | Reporter: | Hugh Davenport <hugh> |
Component: | Architecture, internals, and plumbing | Assignee: | Hugh Davenport <hugh> |
Status: | CLOSED WONTFIX | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel, dcook, kyle.m.hall, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 4437 | ||
Bug Blocks: | 4439 | ||
Attachments: | bug 9412 Add optional_params sub to C4::Service |
Description
Hugh Davenport
2013-01-17 05:15:30 UTC
Created attachment 14651 [details] [review] bug 9412 Add optional_params sub to C4::Service Similar to require_params, but just returns undef for any param that wasn't sent by request Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Self-signed I think this needs a test plan. Failed QA for the following reasons: 1) No test plan 2) Adds a subroutine that is not used Can you please justify the addition of this new subroutine when it isn't used by any new code? Hi Kyle, Sorry, when I git bz'd the patch up here, it didn't take into account dependencies which I guess I kinda assumed it would. This bug is actually building blocks for bug 4439 which then use this method. I've updated this bug to show this dependency. Cheers, Hugh Still valid? This is a legacy module and the linked bug doesn't need C4::Service either |