|
Description
Nicole C. Engard
2013-01-31 20:25:28 UTC
We need the same thing ASAP. We just added a few bookmobiles which need floating between their parent libraries and are shifting priorities to try to solve this issue ASAP. This is an awkward pending issue for us and hopefully I can deliver an acceptable solution soon. Created attachment 40077 [details] [review] Bug 9525 - group floating rules Cucumber integration tests included. run t/Cucumber/runCucumberTests.pl --tags @floatingMatrix Hi, nice feature! Can you please add a test plan? Also some files need a Licence and others need an updated one (from 2 -> 3) Hi Bernardo. Sorry I must focus on other things. I am happy I even managed to rebase and push all things to bugzilla. If you like it, you can write a test plan. Tho I am 100% sure the dependencies will go stale in 1 week and then nobody but a programmer can test this :) And that kind of testing implies a code review. But it is a nice feature and works remarkably well for us. (In reply to Olli-Antti Kivilahti from comment #5) > But it is a nice feature and works remarkably well for us. Great :) Is it possible a short description of the use case scenario? Created attachment 40102 [details]
Admin menu screenshot, how to navigate to the control panel
Created attachment 40103 [details]
The floating matrix control panel where you configure the 4 types of floating between routes.
This screenshot: The floating matrix control panel where you configure the 4 types of floating between routes. Explains how to use this feature. Then just check-in Items and they float based on the rules. If you don't want to use this feature, don't set any floating routes and it is completely unintrusive. Thanks for pushing Bernardo. I hope images are worth more than 100 words ;) In production for ~3 weeks. Working fine and helping a lot! Would test if it had a test plan. +-----------------------------+
| USAGE TIPS (sorry didn't document these in the GUI |
+-----------------------------+
When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule.
The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression.
+-----------------------------+
| SETTING UP THE TEST CONTEXT |
+-----------------------------+
-2. Set syspref "HomeOrHoldingBranchReturn" to homebranch.
-1. Find an Item, which can be circulated freely, and has homebranch B and
any holdingbranch.
0. Read the instructions at admin/floating-matrix.pl.
+-----------+
| TEST PLAN: Disabled floating:
+-----------+
0. Make sure that the floating rules from branch A to branch B (A -> B) are
"Disabled" and vice versa (B -> A).
1. Set your current library to A.
2. Check-in the Item.
3. Observe the started transport to branch B.
4. Set your current library to B.
5. Check-in to receive the transfer.
+-----------+
| TEST PLAN: Always floating:
+-----------+
0. Make sure that the floating rules from branch A to branch B (A -> B) are
"Allowed".
1. Set your current library to A.
2. Check-in the Item.
3. Observe that there is not transport prompt to branch B and the Item is not
"in-transit" -state.
+-----------+
| TEST PLAN: Possibly floating:
+-----------+
0. Make sure that the floating rules from branch A to branch B (A -> B) are
"Possible".
1. Set your current library to A.
2. Check-in the Item.
3. Observe that there is a transport prompt to branch B. You can decide if you
want to transfer or no.
+-----------+
| TEST PLAN: Conditional floating:
+-----------+
0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating.
Created attachment 44754 [details] [review] Bug 9525 - group floating rules, floating rule tester :) Implemented a tester to floating-matrix.pl to more easily test the changes in the floating rules matrix "FloMax". Created attachment 44756 [details] [review] Bug 9525 - group floating rules, floating rule tester :) Created attachment 44760 [details] [review] Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. instead of DELETE we GET the delete request so CGI works with it. 40077 - Bug 9525 - group floating rules 44756 - Bug 9525 - group floating rules, floating rule tester :) 44760 - Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9525 - group floating rules fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9525 - group floating rules When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9525---group-floating-rules-MxbdS8.patch Hi! This feature work really well :) :) :) We are going to rebase it this summer (hopefully) Created attachment 48310 [details] [review] Bug 9525 - group floating rules - added logging ALWAYS and CODITIONAL floats. SELECT * FROM action_logs WHERE module = "FLOATING"; Latest code for this feature can be found from our GitHub: https://github.com/KohaSuomi/kohasuomi Look for commits starting with the tag "Bug 9525 - " We are porting all our code to master presently and hopefully by Q1 2017 we have updated patches here in Bugzilla. Looks like this needs to be rebased to the REST API as well. Created attachment 100420 [details] [review] Bug 9525: Group floating rules Rebased with latest version from https://github.com/KohaSuomi/kohasuomi. Patch combines all previously made patches for this feature. To test follow test plan in comment 13. Created attachment 100421 [details] [review] Bug 9525: Fixing floating on return Created attachment 100422 [details] [review] Bug 9525: Add support for regexps in conditional floating clauses I got a couple of conflicts when applying these patches but was able to resolve them. However, I get an error when running the database update: ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' (errno: 150) (In reply to Owen Leonard from comment #24) > ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' > (errno: 150) Is this because I was supposed to apply the last three patches on top of the remote github branch? > Look for commits starting with the tag "Bug 9525 - " Sorry I don't know what this means. I'm accustomed to seeing a separate testing branch. (In reply to Owen Leonard from comment #25) > (In reply to Owen Leonard from comment #24) > > ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' > > (errno: 150) Hm, it seems I missed that in kohastructure.pl there was: ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci instead of: ENGINE = InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci That's likely the issue here. I'll recheck patches for any other possible problems and reattach them later. > Is this because I was supposed to apply the last three patches on top of the > remote github branch? > > Look for commits starting with the tag "Bug 9525 - " > > Sorry I don't know what this means. I'm accustomed to seeing a separate > testing branch. No need to use remote branch or look commits related to this, all latest code is included here and should work after I fix this issue with database. >I got a couple of conflicts when applying these patches but was able to resolve them. Anything I could look into? Created attachment 100741 [details] [review] Bug 9525: Group floating rules +-----------------------------+ | USAGE TIPS (sorry didn't document these in the GUI | +-----------------------------+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-----------------------------+ | SETTING UP THE TEST CONTEXT | +-----------------------------+ -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +-----------+ | TEST PLAN: Disabled floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +-----------+ | TEST PLAN: Always floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +-----------+ | TEST PLAN: Possibly floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +-----------+ | TEST PLAN: Conditional floating: +-----------+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. +-----------+ | TEST PLAN: Floating rule tester: +-----------+ 0. Add some floating rules between libraries 1. Choose origin library, destination library and give barcode for the item you want to test 2. Hit "Test" 3. Make sure box next to the "Test" button changes color according rules you made 4. Also for conditional floating use barcode for item that doesn't match given condition Created attachment 100742 [details] [review] Bug 9525: Fixing floating on return Created attachment 100743 [details] [review] Bug 9525: Add support for regexps in conditional floating On biblibre sandbox, impossible to apply the patch : Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 9525: Group floating rules Created attachment 103828 [details] [review] Bug 9525: Group floating rules Rebased patch and moved schema changes into a separate patch. Created attachment 103829 [details] [review] Bug 9525: Schema changes - DO NOT PUSH Created attachment 103830 [details] [review] Bug 9525: Fixing floating on return Created attachment 103831 [details] [review] Bug 9525: Add support for regexps in conditional floating clauses 103828 - Bug 9525: Group floating rules 103829 - Bug 9525: Schema changes - DO NOT PUSH 103830 - Bug 9525: Fixing floating on return 103831 - Bug 9525: Add support for regexps in conditional floating clauses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9525: Group floating rules Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 9525: Group floating rules Created attachment 112550 [details] [review] Bug 9525: Group floating rules +-----------------------------+ | USAGE TIPS (sorry didn't document these in the GUI | +-----------------------------+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-----------------------------+ | SETTING UP THE TEST CONTEXT | +-----------------------------+ -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +-----------+ | TEST PLAN: Disabled floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +-----------+ | TEST PLAN: Always floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +-----------+ | TEST PLAN: Possibly floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +-----------+ | TEST PLAN: Conditional floating: +-----------+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. +-----------+ | TEST PLAN: Floating rule tester: +-----------+ 0. Add some floating rules between libraries 1. Choose origin library, destination library and give barcode for the item you want to test 2. Hit "Test" 3. Make sure box next to the "Test" button changes color according rules you made 4. Also for conditional floating use barcode for item that doesn't match given condition Created attachment 112551 [details] [review] Bug 9525: Schema changes - DO NOT PUSH Created attachment 112552 [details] [review] Bug 9525: Fixing floating on return Created attachment 112553 [details] [review] Bug 9525: Add support for regexps in conditional floating clauses itype =~ ^(KI|DV) or location eq 'SHELF' Rebased patches. We are currently working on upcoming version update and have decided to ditch this floating matrix feature. Instead we've decided use float groups which work like hold groups introduced in bug 22284. Created attachment 124825 [details] [review] Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Created attachment 124826 [details] [review] Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy Created attachment 124827 [details] [review] Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Created attachment 133071 [details] [review] Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Created attachment 133072 [details] [review] Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy Created attachment 133073 [details] [review] Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Rebased patches and made database update idempotent. Created attachment 139024 [details] [review] Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Created attachment 139025 [details] [review] Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Created attachment 139026 [details] [review] Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Worked as expected. Tested with various item types & configurations. Lisette not ok 2 - 2nd float group also contains 2 libraries
# Failed test '2nd float group also contains 2 libraries'
# at t/db_dependent/Koha/Libraries.t line 358.
# got: '1'
# expected: '2'
Created attachment 143740 [details] [review] Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Created attachment 143741 [details] [review] Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Created attachment 143742 [details] [review] Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Created attachment 143743 [details] [review] Bug 9525: Fix tests To test prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Rebased patches and fixed tests. Hi, My name is Charlie, I'm the Technical Services Librarian at the County of San Luis Obispo. We are interested in partnering up with anyone that would like to help pay for this bug to be a priority solve. Please let me know if you're interested and I can be reached at <carthur@slolibrary.org>. Thank you, Charlie (In reply to carthur@slolibrary.org from comment #60) > Hi, > > My name is Charlie, I'm the Technical Services Librarian at the County of > San Luis Obispo. We are interested in partnering up with anyone that would > like to help pay for this bug to be a priority solve. > > Please let me know if you're interested and I can be reached at > <carthur@slolibrary.org>. > > Thank you, > Charlie Hi Charly, I have updated the "change sponsored?" field to say "Seeking cosponsors". It might help to get this some attention. (In reply to Katrin Fischer from comment #61) > (In reply to carthur@slolibrary.org from comment #60) > > Hi, > > > > My name is Charlie, I'm the Technical Services Librarian at the County of > > San Luis Obispo. We are interested in partnering up with anyone that would > > like to help pay for this bug to be a priority solve. > > > > Please let me know if you're interested and I can be reached at > > <carthur@slolibrary.org>. > > > > Thank you, > > Charlie > > Hi Charly, I have updated the "change sponsored?" field to say "Seeking > cosponsors". It might help to get this some attention. Hm, I realize now: this patch is already in development. What it needs right now is someone to test it, and anyone can. You could use a sandbox to test and help progress this development. See: https://wiki.koha-community.org/wiki/Development_workflow https://wiki.koha-community.org/wiki/Sandboxes Signed by Lisette, minor rebase and test updates, I think this can go to QA Created attachment 150241 [details] [review] Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150242 [details] [review] Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150243 [details] [review] Bug 9525: Fix tests To test prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150244 [details] [review] Bug 9525: DO NOT PUSH! Schema update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150245 [details] [review] Bug 9525: (QA follow-up) Fix QA complaints Add boolean to schema Remove stray console.log Fix subroutine name in POD Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150246 [details] [review] Bug 9525: (QA follow-up) Clarify how float groups are selected in circulation rules Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I had been testing this on a branch, minor rebase to make apply. All works well, added one patch to clarify how groups are searched, and addressed some simple QA complaints Created attachment 156330 [details] [review] Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 156331 [details] [review] Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 156332 [details] [review] Bug 9525: Fix tests To test prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 156333 [details] [review] Bug 9525: DO NOT PUSH! Schema update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 156334 [details] [review] Bug 9525: (QA follow-up) Fix QA complaints Add boolean to schema Remove stray console.log Fix subroutine name in POD Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 156335 [details] [review] Bug 9525: (QA follow-up) Clarify how float groups are selected in circulation rules Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 156336 [details] [review] Bug 9525: (QA follow-up) Tidy Pushed to master for 23.11. Nice work everyone, thanks! New feature not pushed to 23.05.x Can we get some release notes for this please? (In reply to Martin Renvoize from comment #80) > Can we get some release notes for this please? I improvised something from the commit messages and what I see in Koha. |