Created attachment 147428 [details] [review] Bug 33075: Add ability to mark an item as floating Test plan: 1. Run updatedatabase.pl, update_dbix_class_files.pl and restart koha 2. Go to "Admin > Koha to MARC mapping" and map items.floating to an item subfield 3. Create an item. 4. Make sure that your configuration allows to check out this item, and when returned to a different library the item should be transfered back to its home library. 5. Check out this item and return it in a different library. It should be transfered. Check in the item in its home library to complete the transfer. 6. Modify the item and in the "floating" subfield put a value different than "0" 7. Check out this item and return it in a different library. There should be no transfer. Item's holding library should be the library where it has been returned
installer/data/mysql/atomicupdate/bug-XXXXX.pl needs to use bug id 33075
Your test plan assumes a circulation rule that doesn't allow floating, with the value in items.floating overriding such that it does. Is the opposite true? If my circ rules says everything should float, can I force specific items to *not* float by setting an items.floating value? This seems like it would best conform to existing circ rule structures if: items.floating is NULL: item follows regular circ rules items.floating = 0: item does not float, regardless of circ rules items.floating = 1: item does float, regardless of circ rules
> If my circ rules says everything should float, can I force specific items to > *not* float by setting an items.floating value? That's an interesting idea, but that's not what this patch does (items.floating is defined as NOT NULL).
I may be being stupid, but in sandbox, I can't find items.floating in the Koha to MARC mapping table.
(In reply to Andrew Auld from comment #5) > I may be being stupid, but in sandbox, I can't find items.floating in the > Koha to MARC mapping table. Did you find it? If not, maybe restarting services helps?
(In reply to Emmi Takkinen from comment #6) > > I can't find items.floating in the > > Koha to MARC mapping table. > > Did you find it? If not, maybe restarting services helps? Unfortunately not.
Is this somehow linked to Bug 9525 ?
(In reply to Fridolin Somers from comment #8) > Is this somehow linked to Bug 9525 ? It seems like the changes in 9525 will require changes here, yeah. This patch treats floating rules as a binary, either on or off. Bug 9525 added a third option that is not represented here.
Needs a patch on REST API api/v1/swagger/definitions/item.yaml