Bug 9526

Summary: Patron statistics table is not pretty, the page needs the circ toolbar added
Product: Koha Reporter: Liz Rea <liz>
Component: CirculationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: trivial    
Priority: P5 - low CC: bgkriegel, gmcharlt, jonathan.druart, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 9526 - Patron statistics table is not pretty, needs circ toolbar
[SIGNED-OFF] Bug 9526 - Patron statistics table is not pretty, needs circ toolbar
Bug 9526 - Patron statistics table is not pretty, needs circ toolbar

Description Liz Rea 2013-01-31 20:36:51 UTC
The patron statistics page in circulation does not follow the styling of the rest of the pages, and doesn't include the circ/member toolbar. It needs to come into line with the rest of the interface.
Comment 1 Owen Leonard 2013-01-31 21:02:41 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-01-31 21:48:58 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-02-01 09:51:22 UTC
Thanks Owen of your patch.

QA comment:

This patch improves the ergonomic of the statistics patron page according to the others patron pages.

Marked as Passed QA.
Comment 4 Jonathan Druart 2013-02-01 09:51:46 UTC
Created attachment 14995 [details] [review]
Bug 9526 - Patron statistics table is not pretty, needs circ toolbar

This patch adds the circ/members toolbar, corrects page title and
breadcrumbs, and adds some handling for column names which are coming
from the database. The table of statistics can display any items table
column specified in the StatisticsFields preference, but we can at least
embed the most obvious cases in the template for human readability: item
type, collection code, location, home library, and holding library.

To test, view the patron statistics page. For a patron with no
statistics you should see a message saying so. For a patron with
statistics you should see human-friendly labels for the columns
referenced above.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as described. No errors.
Wouldn't be better with centered cell contents?

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
FIX a typo:
- <h3>Statistcs for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3>
+ <h3>Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3>
Comment 5 Jared Camins-Esakov 2013-02-01 16:18:36 UTC
This patch has been pushed to master.