Summary: | Filters on suggestion page in intranet are broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | bgkriegel, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
screenshot
Bug 9653: FIX collapse class is used by already Bootstrap [SIGNED-OFF] Bug 9653: FIX collapse class is used by already Bootstrap [PASSED QA] Bug 9653: FIX collapse class is used by already Bootstrap |
Something on pushed Bug 9420 makes legends disappear. Looks like Bootstrap has a built-in "collapse" class which is interfering with the class we use on the filters. We should probably replace our custom-built implementation here and use the jQueryUI accordion widget which we already use elsewhere. Created attachment 15550 [details] [review] Bug 9653: FIX collapse class is used by already Bootstrap Quick, simple and dirty fix. Test plan: Apply this patch and check that filters are present on the suggestion management page. Created attachment 15584 [details] [review] [SIGNED-OFF] Bug 9653: FIX collapse class is used by already Bootstrap Quick, simple and dirty fix. Test plan: Apply this patch and check that filters are present on the suggestion management page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 15877 [details] [review] [PASSED QA] Bug 9653: FIX collapse class is used by already Bootstrap Quick, simple and dirty fix. Test plan: Apply this patch and check that filters are present on the suggestion management page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Filters are back on the page, regression fixed. This patch has been pushed to master. |
Created attachment 15463 [details] screenshot The filters on the suggestion page in staff are only showing blue boxes without any content (see screenshot).