Bug 9653 - Filters on suggestion page in intranet are broken
Summary: Filters on suggestion page in intranet are broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-17 12:47 UTC by Katrin Fischer
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot (36.38 KB, image/png)
2013-02-17 12:47 UTC, Katrin Fischer
Details
Bug 9653: FIX collapse class is used by already Bootstrap (4.66 KB, patch)
2013-02-19 16:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9653: FIX collapse class is used by already Bootstrap (4.76 KB, patch)
2013-02-21 13:14 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 9653: FIX collapse class is used by already Bootstrap (4.82 KB, patch)
2013-03-05 07:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-02-17 12:47:23 UTC
Created attachment 15463 [details]
screenshot

The filters on the suggestion page in staff are only showing blue boxes without any content (see screenshot).
Comment 1 Bernardo Gonzalez Kriegel 2013-02-17 12:59:37 UTC
Something on pushed Bug 9420 makes legends disappear.
Comment 2 Owen Leonard 2013-02-18 17:11:48 UTC
Looks like Bootstrap has a built-in "collapse" class which is interfering with the class we use on the filters. We should probably replace our custom-built implementation here and use the jQueryUI accordion widget which we already use elsewhere.
Comment 3 Jonathan Druart 2013-02-19 16:00:37 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2013-02-21 13:14:54 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-03-05 07:42:24 UTC
Created attachment 15877 [details] [review]
[PASSED QA] Bug 9653: FIX collapse class is used by already Bootstrap

Quick, simple and dirty fix.

Test plan:
Apply this patch and check that filters are present on the suggestion
management page.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Filters are back on the page, regression fixed.
Comment 6 Jared Camins-Esakov 2013-03-07 14:29:05 UTC
This patch has been pushed to master.