Summary: | Z39.50 Card View broken in CCSR | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Cataloging | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, colin.campbell, kyle.m.hall, m.de.rooy |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 9684 : Correct path to compact.xsl [PASSED QA] Bug 9684 : Correct path to compact.xsl |
Description
Nicole C. Engard
2013-02-21 14:32:16 UTC
catalogue/showmarc.pl constructs the path to compact.xsl incorrectly ( it blends staff and opac bizarrely) Have a fix - waiting on site who reported this to confirm it works for them Created attachment 17727 [details] [review] Proposed patch Unable to reproduce on master or 3.10.x. If this is still a valid bug, please provide a test plan. Kyle, It is still a bug but only if you're using the CCSR theme: Test plan: * Set sys pref to use CCSR * Do a Z39.50 Search * Click 'card' on one of the results * confirm that there is no error. Created attachment 17739 [details] [review] [SIGNED-OFF] Bug 9684 : Correct path to compact.xsl When try to display card view of retrieved record error occurred as compact.xsl could not be found script was constructing path as though it was opac Also added fallback to en version if no xsl file found under current lang as done in opac-showmarc.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Test plan: * Set sys pref to use CCSR * Do a Z39.50 Search * Click 'card' on one of the results * confirm that there is no error. All test pass Created attachment 17746 [details] [review] [PASSED QA] Bug 9684 : Correct path to compact.xsl When try to display card view of retrieved record error occurred as compact.xsl could not be found script was constructing path as though it was opac Also added fallback to en version if no xsl file found under current lang as done in opac-showmarc.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Test plan: * Set sys pref to use CCSR * Do a Z39.50 Search * Click 'card' on one of the results * confirm that there is no error. All test pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I am astonished that opacthemes affects Z39.50 search in staff so this might be fixing a bigger problem. Checked that clicking on Card works for both themes now correctly after I confirmed the bug. Also all views in OPAC were checked for both themes. All tests and QA script pass. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 |