| Summary: | No alert appears on adding an order to a basket if the budget has exceeded | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | chris, fridolin.somers, gmcharlt, koha, nengard, pelletiermaxime |
| Version: | 3.14 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Medium patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 4266 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 9822: Alert on adding an order to a basket if budget has exceeded
Bug 9822: Alert on adding an order to a basket if budget has exceeded Bug 9822: Alert on adding an order to a basket if budget has exceeded Bug 9822: Alert on adding an order to a basket if budget has exceeded Bug 9822: Alert on adding an order to a basket if budget has exceeded |
||
|
Description
Jonathan Druart
2013-03-15 10:41:09 UTC
Created attachment 16160 [details] [review] Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields *** Bug 1822 has been marked as a duplicate of this bug. *** I create a new fund with warning fields (% and amount). I try all the combinations : the appropriate warning message appears. If you don't confirm the command, there's no problem. But, if you choose to confirm the command, there's a error " Software error: Tag "" is not a valid tag. at /usr/share/perl5/MARC/File/SAX.pm line 92" When I go back to the basket, the line is well recorded. Created attachment 16257 [details] [review] Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields Created attachment 16261 [details] [review] Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields ok, everything works fine this time ! Created attachment 16314 [details] [review] Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Created attachment 19092 [details] [review] Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Pushed to master. Thanks, Jonathan! *** Bug 6832 has been marked as a duplicate of this bug. *** |