Summary: | OpenILS/QueryParser.pm not (always) installed when installing from tarball | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | blocker | ||
Priority: | P5 - low | CC: | claire.hernandez, magnus, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9843: Include OpenILS directory in Perl lib directory
[SIGNED-OFF] Bug 9843: Include OpenILS directory in Perl lib directory [PASSED QA] Bug 9843: Include OpenILS directory in Perl lib directory |
Description
Jared Camins-Esakov
2013-03-19 12:09:19 UTC
Created attachment 16375 [details] [review] Bug 9843: Include OpenILS directory in Perl lib directory When installing from the tarball, the OpenILS/QueryParser.pm file seems to be missed because it is not included in Makefile.PL... sometimes. To test: 1) Run Makefile.PL and make. 2) Look in blib/PERL_MODULE_DIR/ and check if the OpenILS directory is there. 3) Apply patch. 4) Rerun Makefile.PL and make. 5) Confirm that OpenILS directory is now in blib/PERL_MODULE_DIR/ regardless of whether or not it was there during step (2). 6) Sign off. We just saw the "Base class package "OpenILS::QueryParser" is empty." error on a package installation too, so this is not just a problem for tarball installations. Created attachment 16412 [details] [review] [SIGNED-OFF] Bug 9843: Include OpenILS directory in Perl lib directory When installing from the tarball, the OpenILS/QueryParser.pm file seems to be missed because it is not included in Makefile.PL... sometimes. To test: 1) Run Makefile.PL and make. 2) Look in blib/PERL_MODULE_DIR/ and check if the OpenILS directory is there. 3) Apply patch. 4) Rerun Makefile.PL and make. 5) Confirm that OpenILS directory is now in blib/PERL_MODULE_DIR/ regardless of whether or not it was there during step (2). 6) Sign off. Note: Confirmed that OpenILS directory is correctly installed in the lib dir, in 'standard' install mode, and also 'single'. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 16416 [details] [review] [PASSED QA] Bug 9843: Include OpenILS directory in Perl lib directory When installing from the tarball, the OpenILS/QueryParser.pm file seems to be missed because it is not included in Makefile.PL... sometimes. To test: 1) Run Makefile.PL and make. 2) Look in blib/PERL_MODULE_DIR/ and check if the OpenILS directory is there. 3) Apply patch. 4) Rerun Makefile.PL and make. 5) Confirm that OpenILS directory is now in blib/PERL_MODULE_DIR/ regardless of whether or not it was there during step (2). 6) Sign off. Note: Confirmed that OpenILS directory is correctly installed in the lib dir, in 'standard' install mode, and also 'single'. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Simple fix for a big problem. This patch has been pushed to master. |