Summary: | Quiet errors in the log from XSLT.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9873 - Quiet errors in the log from XSLT.pm
Bug 9873 - Quiet errors in the log from XSLT.pm [PASSED QA] Bug 9873 - Quiet errors in the log from XSLT.pm |
Description
Owen Leonard
2013-03-20 14:58:30 UTC
Created attachment 16535 [details] [review] Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. Created attachment 17018 [details] [review] Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17067 [details] [review] [PASSED QA] Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Cleans up logs for result list quite a bit. Passes all tests and QA script. This patch has been pushed to master. This doesn't apply to 3.10.x please send a new patch if you wish it back ported |