Summary: | Missing perl modules in Koha | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | Architecture, internals, and plumbing | Assignee: | Mason James <mtj> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 9172 | ||
Attachments: |
Bug 9926 - Missing perl modules in Koha
[SIGNED-OFF] Bug 9926 - Missing perl modules in Koha Bug 9926 - Missing perl modules in Koha [SIGNED-OFF] Bug 9926 - Missing perl modules in Koha Bug 9926 - Missing perl modules in Koha |
Description
Mason James
2013-03-26 05:50:13 UTC
Created attachment 16879 [details] [review] Bug 9926 - Missing perl modules in Koha This patch lacks a commit message and a test plan. Created attachment 16881 [details] [review] [SIGNED-OFF] Bug 9926 - Missing perl modules in Koha Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Coment: Owen is right, no commit message, no test plan. Please, don't forget. No errors. Test 1) before applying, koha_perl_deps.pl -a do not list File::Slurp as requirement 2) after applying patch, now it list File::Slurp as requirement. (In reply to comment #3) > 2) after applying patch, now it list File::Slurp as requirement. My objection is to the lack of a description of the problem caused by the missing dependency and a way to test that the problem has gone away. Testing that the requirement shows up is only part of the process IMO. Created attachment 16918 [details] [review] Bug 9926 - Missing perl modules in Koha to test… 1) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should *not* get 'syntax OK' returned from command 2) apply patch, and install File::Slurp module $ sudo cpanm File::Slurp 3) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should now get 'syntax OK' returned from command Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 16920 [details] [review] [SIGNED-OFF] Bug 9926 - Missing perl modules in Koha to test… 1) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should *not* get 'syntax OK' returned from command 2) apply patch, and install File::Slurp module $ sudo cpanm File::Slurp 3) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should now get 'syntax OK' returned from command Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Without File:Slurp 1) complains of missing module, with module then sintax Ok. No errors. QA comment: File::Slurp is required. I didn't test with a previous version. Marked as Passed QA. Created attachment 16983 [details] [review] Bug 9926 - Missing perl modules in Koha to test… 1) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should *not* get 'syntax OK' returned from command 2) apply patch, and install File::Slurp module $ sudo cpanm File::Slurp 3) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should now get 'syntax OK' returned from command Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Without File:Slurp 1) complains of missing module, with module then sintax Ok. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |