Summary: | Social icons missing in CSSR theme | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 9935 - Social icons missing in CSSR theme Bug 9935 - Social icons missing in CSSR theme |
Description
Fridolin Somers
2013-03-27 10:04:42 UTC
Created attachment 16926 [details] [review] Proposed patch See commit comment Created attachment 16954 [details] [review] Bug 9935 - Social icons missing in CSSR theme When using CSSR theme, opac.css is missing css rules for social networks Facebook, LinkedIn ... This patch copies css rules related to social netxork from prog theme to cssr theme. Also copies social-sprite.png image. Test plan : - Set CSSR theme : syspref opacthemes=ccsr and opaccolorstylesheet=colors.css - Set syspref SocialNetworks=Enable - Go to a detail page at OPAC => check that social links are icons : Facebook, LinkedIn, Delicious, Send by email, Google Plus and Tweeter Signed-off-by: Liz Rea <liz@catalyst.net.nz> Social icons now showing, thanks! QA comment: Add missing icons for the social networks feature using CSSR theme. Marked as Passed QA. Created attachment 16973 [details] [review] Bug 9935 - Social icons missing in CSSR theme When using CSSR theme, opac.css is missing css rules for social networks Facebook, LinkedIn ... This patch copies css rules related to social netxork from prog theme to cssr theme. Also copies social-sprite.png image. Test plan : - Set CSSR theme : syspref opacthemes=ccsr and opaccolorstylesheet=colors.css - Set syspref SocialNetworks=Enable - Go to a detail page at OPAC => check that social links are icons : Facebook, LinkedIn, Delicious, Send by email, Google Plus and Tweeter Signed-off-by: Liz Rea <liz@catalyst.net.nz> Social icons now showing, thanks! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.5 |