| Summary: | Improve integration of report plugins with existing reports | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Reports | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | Failed QA --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | dcook, jonathan.druart, paola.rossi |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9965 - Improve integration of report plugins with existing reports
sign off of the patch |
||
|
Description
Kyle M Hall (khall)
2013-04-01 18:31:21 UTC
Created attachment 17108 [details] [review] Bug 9965 - Improve integration of report plugins with existing reports Right now we have a link to in the Reports module to access all report plugins. It would probably be better for the report plugins were just listed on the reports page directly. Test Plan: 1) Install one or more report plugins 2) Apply patch 3) Browse to reports-home.pl 4) Observe the report plugins are listed under 'Other reports' Created attachment 18039 [details] [review] sign off of the patch QA comment:
1/ There are 3 tabulation characters:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
FAIL forbidden patterns
The patch introduces a forbidden pattern: tabulation character (73)
The patch introduces a forbidden pattern: withespace character (74)
The patch introduces a forbidden pattern: tabulation character (15)
2/ The conditional test in reports-home.tt should be
[% IF UseKohaPlugins && CAN_user_plugins_report && plugins %]
Otherwise a single h2 title is displayed.
3/ Why do you change "Report plugins" with "Other reports" while a "Others" already exists?
Marked as Failed QA.
Since we're already doing this for Tools, it would be nice to do it for Reports too. |