Bug 9965 - Improve integration of report plugins with existing reports
Summary: Improve integration of report plugins with existing reports
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 18:31 UTC by Kyle M Hall
Modified: 2016-06-23 12:35 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9965 - Improve integration of report plugins with existing reports (4.12 KB, patch)
2013-04-01 18:33 UTC, Kyle M Hall
Details | Diff | Splinter Review
sign off of the patch (4.22 KB, patch)
2013-05-09 12:49 UTC, Paola Rossi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-04-01 18:31:21 UTC
Right now we have a link to in the Reports module to access all report plugins. It would probably be better for the report plugins were just listed on the reports page directly.
Comment 1 Kyle M Hall 2013-04-01 18:33:40 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2013-05-09 12:49:27 UTC
Created attachment 18039 [details] [review]
sign off of the patch
Comment 3 Jonathan Druart 2013-05-23 10:50:13 UTC
QA comment:

1/ There are 3 tabulation characters:
 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
   FAIL	  forbidden patterns
		The patch introduces a forbidden pattern: tabulation character (73)
		The patch introduces a forbidden pattern: withespace character  (74)
		The patch introduces a forbidden pattern: tabulation character (15)

2/ The conditional test in reports-home.tt should be
      [% IF UseKohaPlugins && CAN_user_plugins_report && plugins %]
Otherwise a single h2 title is displayed.

3/ Why do you change "Report plugins" with "Other reports" while a "Others" already exists?

Marked as Failed QA.