Bug 9978

Summary: Update GNU licenses header in Koha files from GPL2 to GPL3
Product: Koha Reporter: Mason James <mtj>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: chris, cnighswonger, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 24545    
Attachments: Bug 9978: Replace license header with the correct license (GPLv3+)
Script used to replace
[SIGNED OFF] Bug 9978: Replace license header with the correct license (GPLv3+)
[SIGNED OFF] Bug 9978: Replace license header with the correct license (GPLv3+)
Bug 9978: Replace license header with the correct license (GPLv3+)
[SIGNED OFF] Bug 9978: Replace license header with the correct license (GPLv3+)
[PASSED QA] Bug 9978: Replace license header with the correct license (GPLv3+)
Bug 9978: (followup) Replace license header with the correct license (GPLv3+)
Bug 9978: (followup 2) Replace license header with the correct license (GPLv3+)
[PASSED QA] Bug 9978: Replace license header with the correct license (GPLv3+)
[PASSED QA] Bug 9978: (followup) Replace license header with the correct license (GPLv3+)

Description Mason James 2013-04-02 21:46:37 UTC
many files in Koha still incorrectly cite the old GPL2+ license, not the current GPL3+ license

this OMNIBUS bug aims to track patches correcting this issue
Comment 1 Jonathan Druart 2015-04-08 15:10:46 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-04-08 15:12:08 UTC
Created attachment 37585 [details]
Script used to replace

perl license_replace.pl `git grep -l 'either version 2 of the License' | xargs`
Comment 3 Chris Nighswonger 2015-04-08 15:19:07 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi (tcohen) 2015-04-08 17:42:28 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2015-04-17 14:21:09 UTC
Hm, some of the files have since been removed - what's the best way to fix those conflicts?
Comment 6 Jonathan Druart 2015-04-17 14:30:08 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2015-04-17 14:30:36 UTC
(In reply to Katrin Fischer from comment #5)
> Hm, some of the files have since been removed - what's the best way to fix
> those conflicts?

It was just 3 deleted files. so git rm files.
Comment 8 Chris Nighswonger 2015-04-17 14:45:10 UTC Comment hidden (obsolete)
Comment 9 Chris Nighswonger 2015-04-17 14:45:52 UTC
Try it now.
Comment 10 Chris Nighswonger 2015-04-17 14:46:43 UTC
Sorry, I lost a signoff in that fix.
Comment 11 Katrin Fischer 2015-04-17 15:07:11 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2015-04-17 15:07:27 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2015-04-17 15:13:54 UTC Comment hidden (obsolete)
Comment 14 Jonathan Druart 2015-04-17 15:15:40 UTC
Comment on attachment 38085 [details] [review]
Bug 9978: (followup 2) Replace license header with the correct license (GPLv3+)

This one does not replace correctly.
Comment 15 Kyle M Hall (khall) 2015-04-17 16:27:18 UTC
Created attachment 38091 [details] [review]
[PASSED QA] Bug 9978: Replace license header with the correct license (GPLv3+)

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

http://bugs.koha-community.org/show_bug.cgi?id=9987

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 16 Kyle M Hall (khall) 2015-04-17 16:27:25 UTC
Created attachment 38092 [details] [review]
[PASSED QA] Bug 9978: (followup) Replace license header with the correct license (GPLv3+)

There was another form of the v2.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 17 Tomás Cohen Arazi (tcohen) 2015-04-20 13:27:48 UTC
Patches pushed to master.

Thanks Jonathan!
Comment 18 Chris Cormack 2015-04-21 23:29:23 UTC
Pushed to 3.18.x will be in 3.18.6