No big deal but inconsistent: git grep -l "gnu.org/licenses"| wc -l 1156 git grep -l "Franklin Street"| wc -l 471 It seems easier to me to go to gnu.org than writing to Boston ? Even in newer files sometimes the older copyright is copied.
Could you add Franklin Street into qa tools to stop new ones, Jonathan?
Created attachment 98232 [details] [review] Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement.
Created attachment 98233 [details] [review] Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now
(In reply to Marcel de Rooy from comment #1) > Could you add Franklin Street into qa tools to stop new ones, Jonathan? We could, please open a new issue on the project's bug tracker.
Created attachment 98270 [details] [review] Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 98271 [details] [review] Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now Signed-off-by: David Nind <david@davidnind.com>
etc/zebradb/authorities/etc/dom-config-marc.xml etc/zebradb/authorities/etc/dom-config.xml etc/zebradb/biblios/etc/dom-config-marc.xml etc/zebradb/biblios/etc/dom-config.xml etc/zebradb/xsl/zebra.xsl koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt koha-tmpl/intranet-tmpl/prog/js/offlinecirc.js xt/find-license-problems.t xt/fix-old-fsf-address Should we still address a few of these ones?
(In reply to Marcel de Rooy from comment #7) > etc/zebradb/authorities/etc/dom-config-marc.xml > etc/zebradb/authorities/etc/dom-config.xml > etc/zebradb/biblios/etc/dom-config-marc.xml > etc/zebradb/biblios/etc/dom-config.xml > etc/zebradb/xsl/zebra.xsl => Zebra license > koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt tiny mce license > koha-tmpl/intranet-tmpl/prog/js/offlinecirc.js Yes, follow-up coming. > xt/find-license-problems.t False positive. > xt/fix-old-fsf-address Yes, follow-up coming.
Created attachment 98278 [details] [review] Bug 24545: (follow-up) Fix license statements
Can you please rebase?
Created attachment 99068 [details] [review] Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99069 [details] [review] Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99070 [details] [review] Bug 24545: (follow-up) Fix license statements
Fasten your seatbelts
Created attachment 99502 [details] [review] Bug 24705: Add tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 99503 [details] [review] Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority Signed-off-by: Christofer Zorn <Christofer.Zorn@ajaxlibrary.ca> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 99504 [details] [review] Bug 24708: Update Z39.50 server attribute in fr-CA installation file Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 99505 [details] [review] Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 99506 [details] [review] Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 99507 [details] [review] Bug 24545: (follow-up) Fix license statements Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
xt/find-license-problems.t # Looks like you failed 6 tests of 1134.
(In reply to Marcel de Rooy from comment #21) > xt/find-license-problems.t > # Looks like you failed 6 tests of 1134. Those are newly added scripts, they need to be fixed as well before push. Follow-up coming.
Created attachment 99513 [details] [review] Bug 24545: Fix newly added files
Nice work everyone! Pushed to master for 20.05
Created attachment 99530 [details] [review] Bug 24545: (follow-up) Fix license statements Oops, missing # here!
New QA check is going to be added on https://gitlab.com/koha-community/qa-test-tools/issues/24
Created attachment 100386 [details] [review] Bug 24545: Cannot return outside of sub We must die instead
Enhancement not backported to 19.11.x