| Summary: | convert ./C4/Installer/PerlDependencies.pm into a YAML file | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mason James <mtj> |
| Component: | Architecture, internals, and plumbing | Assignee: | Mason James <mtj> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, mirko, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file
Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file |
||
|
Description
Mason James
2013-04-02 22:23:58 UTC
Created attachment 17741 [details] [review] Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file to test... - run 'before' dependancy test ./koha_perl_deps.pl -a > aa - apply patch git bz 9979 - run 'after' dependancy test ./koha_perl_deps.pl -a > bb - test for 0 differences diff aa bb |wc -l 0 - run test perl ./t/Installer_PerlDependencies.t 1..3 ok 1 - use C4::Installer::PerlDependencies; ok 2 - PerlDependencies.yml file parsed with no errors ok 3 - Parsed YAML matches PerlDependencies.yml file Created attachment 17752 [details] [review] Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file to test... - run 'before' dependancy test ./koha_perl_deps.pl -a > aa - apply patch git bz 9979 - run 'after' dependancy test ./koha_perl_deps.pl -a > bb - test for 0 differences diff aa bb |wc -l 0 - run test perl ./t/Installer_PerlDependencies.t 1..3 ok 1 - use C4::Installer::PerlDependencies; ok 2 - PerlDependencies.yml file parsed with no errors ok 3 - Parsed YAML matches PerlDependencies.yml file Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Mason, could you rebase your patch against master please? qa comment: I think the yaml file should be somewhere else than into a C4 sub-directory. But I don't have a better suggestion... (In reply to Mason James from comment #0) > the current file in Koha with perl module data is not too user friendly > > this bug aims to replace it with a friendlier YAML version Can you expand on why you find this so unfriendly? Or why other developers would find it unfriendly, to well, write Perl code? Or provide use cases? Putting aside the current inability of the patch to apply, at the moment this seems to me to be a change purely for the sake of making a change. That's not to say that I have any particular attachment to the status quo in this case -- it would have been quite reasonable for Chris Nighswonger to have chosen YAML or JSON back in 2010 -- but the current state of affairs is also reasonable. Should this Bug have status "In Discussion"? (In reply to Marc Véron from comment #5) > Should this Bug have status "In Discussion"? yeah, i'll switch it... (In reply to Galen Charlton from comment #4) > (In reply to Mason James from comment #0) > > the current file in Koha with perl module data is not too user friendly > > > > this bug aims to replace it with a friendlier YAML version > > Can you expand on why you find this so unfriendly? Or why other developers > would find it unfriendly, to well, write Perl code? Or provide use cases? Galen, currently, how can developers access Koha's required perl modules, using a different programming language than perl? afaik, they cant - thats unfriendly :( |