Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file
Summary: convert ./C4/Installer/PerlDependencies.pm into a YAML file
Status: RESOLVED DUPLICATE of bug 19735
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Mason James
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 22:23 UTC by Mason James
Modified: 2020-02-12 14:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file (29.84 KB, patch)
2013-04-27 08:18 UTC, Mason James 		Details | Diff | Splinter Review
Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file (29.86 KB, patch)
2013-04-27 12:38 UTC, Mirko Tietgen 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2013-04-02 22:23:58 UTC 
the current file in Koha with perl module data is not too user friendly

this bug aims to replace it with a friendlier YAML version
Comment 1 Mason James 2013-04-27 08:18:43 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-04-27 12:38:14 UTC 
Created attachment 17752 [details] [review]
Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file

to test...

- run 'before' dependancy test
    ./koha_perl_deps.pl -a > aa

- apply patch
    git bz 9979

- run 'after' dependancy test
    ./koha_perl_deps.pl -a > bb

- test for 0 differences
    diff aa bb |wc -l
    0

- run test
    perl ./t/Installer_PerlDependencies.t
    1..3
    ok 1 - use C4::Installer::PerlDependencies;
    ok 2 - PerlDependencies.yml file parsed with no errors
    ok 3 - Parsed YAML matches PerlDependencies.yml file

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 3 Jonathan Druart 2013-05-02 13:37:58 UTC 
Mason, could you rebase your patch against master please?

qa comment:
I think the yaml file should be somewhere else than into a C4 sub-directory. But I don't have a better suggestion...
Comment 4 Galen Charlton 2013-07-23 20:03:59 UTC 
(In reply to Mason James from comment #0)
> the current file in Koha with perl module data is not too user friendly
> 
> this bug aims to replace it with a friendlier YAML version

Can you expand on why you find this so unfriendly?  Or why other developers would find it unfriendly, to well, write Perl code?  Or provide use cases?

Putting aside the current inability of the patch to apply, at the moment this seems to me to be a change purely for the sake of making a change.

That's not to say that I have any particular attachment to the status quo in this case -- it would have been quite reasonable for Chris Nighswonger to have chosen YAML or JSON back in 2010 -- but the current state of affairs is also reasonable.
Comment 5 Marc Véron 2014-08-20 08:12:38 UTC 
Should this Bug have status "In Discussion"?
Comment 6 Mason James 2014-08-21 03:55:00 UTC 
(In reply to Marc Véron from comment #5)
> Should this Bug have status "In Discussion"?

yeah, i'll switch it...
Comment 7 Mason James 2014-08-21 04:09:17 UTC 
(In reply to Galen Charlton from comment #4)
> (In reply to Mason James from comment #0)
> > the current file in Koha with perl module data is not too user friendly
> > 
> > this bug aims to replace it with a friendlier YAML version
> 
> Can you expand on why you find this so unfriendly?  Or why other developers
> would find it unfriendly, to well, write Perl code?  Or provide use cases?

Galen, currently, how can developers access Koha's required perl modules, using a different programming language than perl?

afaik, they cant - thats unfriendly :(
Comment 8 Jonathan Druart 2020-02-12 14:33:30 UTC 
Replaced by bug 19735 (using a cpanfile instead).

*** This bug has been marked as a duplicate of bug 19735 ***