Summary: | Style 'Cancel' link like buttons | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
Description
Mathieu Saby
2013-10-17 18:14:35 UTC
I disagree. Here's my comment from the similar Bug 4325: They are supposed to be styled as links. In most cases, the "cancel" action is not any kind of form submission, it's just a link back to a view or whatever the previous action was. In cases where a form submission might be required, styling the action to match existing patterns gives us a button styled like a link. In addition, the distinctly different style of the "cancel" action is a visual cue to users that the action isn't the primary one: Users do not have to spend a long time examining the labels to determine which button is the submit and which is the cancel. This should reduce errors. I don't believe this should be changed. I agree with Owen's argument about the primary action being more obvious. I am actually quite fond of the styling like it is now. Well, I found that not very nice, and a bit surprizing, but you are true, it makes the difference between "Cancel" and "Save" very obvious, that's an advantage. Regarding the use of buttons and links, Koha is not always consistent. For example, in basket table, you have links for actions (like cancelling an order...), but in basketgroups table, you have buttons for actions (edit/close and print/reopen etc). Mathieu (In reply to mathieu saby from comment #3) > Regarding the use of buttons and links, Koha is not always consistent. For > example, in basket table, you have links for actions (like cancelling an > order...), but in basketgroups table, you have buttons for actions > (edit/close and print/reopen etc). I agree with this, and I think there are a lot of places where we should start to use alternate solutions like Bootstrap buttons or menus (for instance, like the recent change to saved reports actions). Also, all the "Cancel" links should have the class "cancel," so it would be very simple to add some custom CSS to change the style globally in the staff client. |