Bug 11076 - Style 'Cancel' link like buttons
Summary: Style 'Cancel' link like buttons
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 18:14 UTC by Mathieu Saby
Modified: 2016-12-05 21:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-10-17 18:14:35 UTC
In many pages, there is a "Cancel" link close to a "Save" or "Submit" button.
It would be nicer if "Cancel" was styled to look like a button.

M. Saby
Comment 1 Owen Leonard 2013-10-17 18:23:07 UTC
I disagree. Here's my comment from the similar Bug 4325:

They are supposed to be styled as links. In most cases, the "cancel" action is not any kind of form submission, it's just a link back to a view or whatever the previous action was. In cases where a form submission might be required, styling the action to match existing patterns gives us a button styled like a link.

In addition, the distinctly different style of the "cancel" action is a visual cue to users that the action isn't the primary one: Users do not have to spend a long time examining the labels to determine which button is the submit and which is the cancel. This should reduce errors.

I don't believe this should be changed.
Comment 2 Katrin Fischer 2013-10-17 19:57:20 UTC
I agree with Owen's argument about the primary action being more obvious. I am actually quite fond of the styling like it is now.
Comment 3 Mathieu Saby 2013-10-17 20:02:39 UTC
Well, I found that not very nice, and a bit surprizing, but you are true, it makes the difference between "Cancel" and "Save" very obvious, that's an advantage.

Regarding the use of buttons and links, Koha is not always consistent. For example, in basket table, you have links for actions (like cancelling an order...), but in basketgroups table, you have buttons for actions (edit/close and print/reopen etc).

Mathieu
Comment 4 Owen Leonard 2013-10-17 22:32:01 UTC
(In reply to mathieu saby from comment #3)

> Regarding the use of buttons and links, Koha is not always consistent. For
> example, in basket table, you have links for actions (like cancelling an
> order...), but in basketgroups table, you have buttons for actions
> (edit/close and print/reopen etc).

I agree with this, and I think there are a lot of places where we should start to use alternate solutions like Bootstrap buttons or menus (for instance, like the recent change to saved reports actions). 

Also, all the "Cancel" links should have the class "cancel," so it would be very simple to add some custom CSS to change the style globally in the staff client.