Summary: | Authority search does not display summary while searching by all auth types | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, fridolin.somers, gitbot, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11131: Authority search does not display summary while searching by all auth types
Bug 11131: Authority search does not display summary while searching by all auth types [PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types |
Description
Jonathan Druart
2013-10-24 13:28:25 UTC
Created attachment 22358 [details] [review] Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') [1;32mOK[0m C4/AuthoritiesMarc.pm Created attachment 23840 [details] [review] Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search <something> by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23858 [details] [review] [PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search <something> by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with a UNIMARC database, works as described. All tests and QA script pass. Pushed to master. Thanks, Jonathan! Patch pushed to 3.14.x, will be in 3.14.3. |