Summary: | Multiple holding branchs and locations not displaying in pending holds report | ||
---|---|---|---|
Product: | Koha | Reporter: | Sophie MEYNIEUX <sophie.meynieux> |
Component: | Circulation | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, chris, f.demians, gmcharlt, julian.maurice, katrin.fischer, kyle.m.hall |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15560: Fix display of multiple branches and locations in pending reserves report
Bug 15560: Fix display of multiple branches and locations in pending reserves report Bug 15560: Fix display of multiple branches and locations in pending reserves report Bug 15560: Fix display of multiple item types in pending reserves report |
Description
Sophie MEYNIEUX
2016-01-12 15:49:55 UTC
why not changing directly the SQL to get branchname rather than branchcode ? Hi Sophie, sorry for causing the bug. :( I will try to fix, but not sure when I will have the time - so if someone wants to have a go, please do! Created attachment 46964 [details] [review] Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Forgot a step in my test plan:
To test:
- Add a record with at least 2 items from different locations and
holdingbranches
>>> Place a hold on it!
- Open the 'holds to pull' report
- Verify all branches and locations show with their correct
description
Created attachment 46967 [details] [review] Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Signed-off-by: Natasha <tasham_8@hotmail.com> Created attachment 46981 [details] [review] Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Signed-off-by: Natasha <tasham_8@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 46982 [details] [review] Bug 15560: Fix display of multiple item types in pending reserves report Same fix as previous patch, but for item types. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |