Bug 15560 - Multiple holding branchs and locations not displaying in pending holds report
Summary: Multiple holding branchs and locations not displaying in pending holds report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2016-01-12 15:49 UTC by Sophie MEYNIEUX
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15560: Fix display of multiple branches and locations in pending reserves report (4.39 KB, patch)
2016-01-20 00:50 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 15560: Fix display of multiple branches and locations in pending reserves report (4.44 KB, patch)
2016-01-20 01:37 UTC, natasha 		Details | Diff | Splinter Review
Bug 15560: Fix display of multiple branches and locations in pending reserves report (4.51 KB, patch)
2016-01-20 09:41 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 15560: Fix display of multiple item types in pending reserves report (2.57 KB, patch)
2016-01-20 09:41 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2016-01-12 15:49:55 UTC 
In pending reserves report, when there are several items spread into several branches, libraries are not displaid any more.

It's due to Bug 12152 that replaces branchcode with branchname but can't deal with a list of branchcodes
Comment 1 Sophie MEYNIEUX 2016-01-13 09:23:50 UTC 
why not changing directly the SQL to get branchname rather than branchcode ?
Comment 2 Katrin Fischer 2016-01-13 09:56:22 UTC 
Hi Sophie, sorry for causing the bug. :( 

I will try to fix, but not sure when I will have the time - so if someone wants to have a go, please do!
Comment 3 Katrin Fischer 2016-01-20 00:50:05 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-01-20 00:55:34 UTC 
Forgot a step in my test plan:

To test:
- Add a record with at least 2 items from different locations and
  holdingbranches
>>> Place a hold on it!
- Open the 'holds to pull' report
- Verify all branches and locations show with their correct
  description
Comment 5 natasha 2016-01-20 01:37:59 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-01-20 09:41:48 UTC 
Created attachment 46981 [details] [review]
Bug 15560: Fix display of multiple branches and locations in pending reserves report

The patches from bug 12152 broke the display on the pending reserves/
holds to pull report when items from multiple branches and with
multiple locations were displayed. The table cells were left empty.

To test:
- Add a record with at least 2 items from different locations and
  holdingbranches
- Open the 'holds to pull' report
- Verify all branches and locations show with their correct
  description

Signed-off-by: Natasha <tasham_8@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2016-01-20 09:41:51 UTC 
Created attachment 46982 [details] [review]
Bug 15560: Fix display of multiple item types in pending reserves report

Same fix as previous patch, but for item types.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Brendan Gallagher 2016-01-23 18:43:17 UTC 
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 9 Julian Maurice 2016-01-25 11:42:06 UTC 
Patch pushed to 3.22.x, will be in 3.22.2
Comment 10 Frédéric Demians 2016-01-25 16:27:31 UTC 
This patch has been pushed to 3.20.x, will be in 3.20.8.