Bug 31011

Summary: Make hold reminders respect patron's language
Product: Koha Reporter: Magnus Enger <magnus>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15986    
Bug Blocks:    

Description Magnus Enger 2022-06-22 12:28:24 UTC
When running misc/cronjobs/holds/holds_reminder.pl it looks like borrowers.lang is not respected. The only code I can see that relates to language is this:

    # FIXME What if we don't want to default if the translated template does not exist?
    my $template_exists = Koha::Notice::Templates->find_effective_template(
        {
            module     => 'reserves',
            code       => $lettercode,
            branchcode => $branchcode,
            lang       => 'default',
        }
    );

As far as I can see, the "default" template is always used?
Comment 1 Katrin Fischer 2022-07-17 11:34:27 UTC
Still valid. There is also another bug that could possibly be fixed at the same time: 

Bug 28797 - Hold reminder email should use All Libraries notice