Bug 32431

Summary: Show date for expired patrons in SIP
Product: Koha Reporter: Matthias Meusburger <matthias.meusburger>
Component: SIP2Assignee: Matthias Meusburger <matthias.meusburger>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Attachments: Bug 32431: Display expiry date on SIP checkout when patron is expired
Bug 32431: Display expiry date on SIP checkout when patron is expired
Bug 32431: Display expiry date on SIP checkout when patron is expired

Description Matthias Meusburger 2022-12-08 14:09:53 UTC
This is an improvement to Bug 25815.

In the case the patron is expired, display the expiry date on checkout.
Comment 1 Matthias Meusburger 2022-12-08 14:13:53 UTC
Created attachment 144498 [details] [review]
Bug 32431: Display expiry date on SIP checkout when patron is expired

Test plan:

 - Set up an expired patron
 - Do a SIP checkout
 - Check that the message is "Patron expired"
 - Apply the patch
 - Check that the message is "Patron expired on <correctly_formatted_date>"
 - Prove t//db_dependent/SIP/Transaction.t
Comment 2 Lucas Gass 2022-12-12 21:01:23 UTC
Created attachment 144545 [details] [review]
Bug 32431: Display expiry date on SIP checkout when patron is expired

Test plan:

 - Set up an expired patron
 - Do a SIP checkout
 - Check that the message is "Patron expired"
 - Apply the patch
 - Check that the message is "Patron expired on <correctly_formatted_date>"
 - Prove t//db_dependent/SIP/Transaction.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Kyle M Hall 2023-01-20 18:56:36 UTC
Created attachment 145553 [details] [review]
Bug 32431: Display expiry date on SIP checkout when patron is expired

Test plan:

 - Set up an expired patron
 - Do a SIP checkout
 - Check that the message is "Patron expired"
 - Apply the patch
 - Check that the message is "Patron expired on <correctly_formatted_date>"
 - Prove t//db_dependent/SIP/Transaction.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-01-30 18:10:52 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!