Bug 32431 - Show date for expired patrons in SIP
Summary: Show date for expired patrons in SIP
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matthias Meusburger
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-08 14:09 UTC by Matthias Meusburger
Modified: 2024-07-04 20:37 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Circulation function:

Attachments
Bug 32431: Display expiry date on SIP checkout when patron is expired (2.22 KB, patch)
2022-12-08 14:13 UTC, Matthias Meusburger 		Details | Diff | Splinter Review
Bug 32431: Display expiry date on SIP checkout when patron is expired (2.27 KB, patch)
2022-12-12 21:01 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 32431: Display expiry date on SIP checkout when patron is expired (2.33 KB, patch)
2023-01-20 18:56 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Meusburger 2022-12-08 14:09:53 UTC 
This is an improvement to Bug 25815.

In the case the patron is expired, display the expiry date on checkout.
Comment 1 Matthias Meusburger 2022-12-08 14:13:53 UTC 
Created attachment 144498 [details] [review]
Bug 32431: Display expiry date on SIP checkout when patron is expired

Test plan:

 - Set up an expired patron
 - Do a SIP checkout
 - Check that the message is "Patron expired"
 - Apply the patch
 - Check that the message is "Patron expired on <correctly_formatted_date>"
 - Prove t//db_dependent/SIP/Transaction.t
Comment 2 Lucas Gass (lukeg) 2022-12-12 21:01:23 UTC 
Created attachment 144545 [details] [review]
Bug 32431: Display expiry date on SIP checkout when patron is expired

Test plan:

 - Set up an expired patron
 - Do a SIP checkout
 - Check that the message is "Patron expired"
 - Apply the patch
 - Check that the message is "Patron expired on <correctly_formatted_date>"
 - Prove t//db_dependent/SIP/Transaction.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Kyle M Hall (khall) 2023-01-20 18:56:36 UTC 
Created attachment 145553 [details] [review]
Bug 32431: Display expiry date on SIP checkout when patron is expired

Test plan:

 - Set up an expired patron
 - Do a SIP checkout
 - Check that the message is "Patron expired"
 - Apply the patch
 - Check that the message is "Patron expired on <correctly_formatted_date>"
 - Prove t//db_dependent/SIP/Transaction.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-01-30 18:10:52 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!