Bug 9266 - Untranslated strings in tags moderation
Summary: Untranslated strings in tags moderation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 19:47 UTC by Marc Véron
Modified: 2013-12-05 20:09 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Error while rejecting tag in translated staff client (German) (21.91 KB, image/jpeg)
2012-12-11 19:47 UTC, Marc Véron
Details
Bug 9266 - Untranslated strings in tags moderation (2.70 KB, patch)
2013-04-26 18:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Signed off patch (2.72 KB, patch)
2013-04-28 00:50 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9266 - Untranslated strings in tags moderation (2.80 KB, patch)
2013-04-29 03:43 UTC, Mason James
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2012-12-11 19:47:08 UTC
Created attachment 14013 [details]
Error while rejecting tag in translated staff client (German)

Rejecting tags results in message: Unbekannte Operation (ablehnen) mit 2 Begriff(en). 

Steps to reproduce:

1) 
Go to Home › Tools › Tags
2)
Filter tags to show a list of tags. Check checkboxes of tags you want to reject. Click "Reject" at the bottom 

Result in English staff client: "Rejected 1 Term(s). "

Result in German Staff client: "Unbekannte Operation (ablehnen) mit 1 Begriff(en)."
(Unknown operation (ablehnen)...)

Same with approve.

I tested on a 3.9 demo server, German translation installed.

Can somebody confirm for newer version and for other languages?
Comment 1 Katrin Fischer 2012-12-27 23:16:39 UTC
Tested in 3.10.1.

I can reproduce the problem using the checkboxes and the buttons below the list of tags.

Also I noted some other translation related problems:

1) On the OPAC detail page there is a little icon in front of 'Add' that is missing in the German templates before 'Hinzufügen'.

2) When you use the 'reject' and 'accept' links in the list of terms, after rejecting or accepting one of the buttons appears in English. Looking like:

Bestätigt (= Accepted) | Reject
Approve | Abgelehnt (= Rejected)
Comment 2 Fridolin Somers 2013-04-24 09:03:26 UTC
This may be corrected by Bug 10022.
Comment 3 Owen Leonard 2013-04-26 18:20:10 UTC
Since the patch for Bug 10022 fixes the original problem described in this bug I'm having Katrin's #2 problem above take over this report:

> 2) When you use the 'reject' and 'accept' links in the list of terms, after
> rejecting or accepting one of the buttons appears in English.

I could not reproduce this problem:

> 1) On the OPAC detail page there is a little icon in front of 'Add' that is
> missing in the German templates before 'Hinzufügen'.
Comment 4 Owen Leonard 2013-04-26 18:31:43 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2013-04-28 00:50:57 UTC Comment hidden (obsolete)
Comment 6 Mason James 2013-04-29 03:43:47 UTC
Created attachment 17778 [details] [review]
Bug 9266 - Untranslated strings in tags moderation

There are a couple of English strings in tags moderation JavaScript
which are not properly enclosed in the _() function enabling
translation. As a result, clicking a translated 'Approve' or
'Reject' button in the table of tags would change the button's
neighbor's label to the English string. This patch
corrects it.

To test, apply the patch and regenerate a translation to test with. Go
to Tools -> Tags and find a list of tags to moderate (pending, approved,
or rejected). When you click on an 'Approve' or 'Reject' tag in the
table of tags, the buttons in each Approve/Reject pair should retain
their correct translated label. For instance, looking at approved tags
in French:

[ Approuvé ] [ Rejeter ]

Clicking the "Rejetee" button should change the state to:

[ Approuver ] [ Rejetée ]

Clicking "Approuver" should return the buttons to the first state.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 7 Mason James 2013-04-29 04:04:11 UTC
> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
> Signed-off-by: Mason James <mtj@kohaaloha.com>

QA-comment: tested ok, passing QA
Comment 8 Jared Camins-Esakov 2013-05-01 11:19:44 UTC
This patch has been pushed to master and 3.12.x.
Comment 9 Chris Cormack 2013-05-09 06:53:33 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13