Bug 10038 - Doubled 'default' entry when creating a new authority type
Summary: Doubled 'default' entry when creating a new authority type
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-13 16:23 UTC by Katrin Fischer
Modified: 2015-06-04 23:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10038: Doubled 'default' entry when creating a new authority type (2.75 KB, patch)
2013-07-17 13:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10038: Doubled 'default' entry when creating a new authority type (3.18 KB, patch)
2013-08-22 13:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10038: Doubled 'default' entry when creating a new authority type (3.38 KB, patch)
2013-09-29 03:00 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 10038: Doubled 'default' entry when creating a new authority type (3.50 KB, patch)
2013-09-29 16:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-04-13 16:23:46 UTC
When creating a new authority type the pulldown for picking an existing framework to base the new framework on has 2 identical entries for 'Default'.

Steps to reproduce:
- Create a new authority type
- Click MARC structure
- Verify the pull down has 2 entries for Default on top of the list
Comment 1 Jonathan Druart 2013-07-17 13:07:00 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2013-08-22 13:04:50 UTC
When you added the auth type but not yet copied the framework, you get a list with label Create authority framework for .. using ..
This list is not yet sorted.
Is that in the scope of this report?
Comment 3 Jonathan Druart 2013-08-22 13:48:07 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2013-09-29 03:00:56 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-09-29 16:20:44 UTC
Created attachment 21596 [details] [review]
[PASSED QA] Bug 10038: Doubled 'default' entry when creating a new authority type

Test plan:
- Create a new authority type
- Click MARC structure
- Verify the pull down has only 1 entry for Default
- Go on the authority type home (admin/authtypes.pl)
- Click on the "MARC structure" link for the default type
- Verify the pull down has only 1 entry for Default

This patch adds a sort (on the authtypecode) for these 2 lists.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Works as described. No koha-qa errors.

When creating a new framework it would be better to have Default
on top, but one is way better than two :)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Agreed, one is better than two :)
All tests and QA script pass.
Comment 6 Galen Charlton 2013-10-18 04:49:04 UTC
Pushed to master.  Thanks, Jonathan!
Comment 7 Tomás Cohen Arazi 2013-12-03 18:11:43 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Jonathan!