When creating a new authority type the pulldown for picking an existing framework to base the new framework on has 2 identical entries for 'Default'. Steps to reproduce: - Create a new authority type - Click MARC structure - Verify the pull down has 2 entries for Default on top of the list
Created attachment 19719 [details] [review] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists.
When you added the auth type but not yet copied the framework, you get a list with label Create authority framework for .. using .. This list is not yet sorted. Is that in the scope of this report?
Created attachment 20553 [details] [review] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists.
Created attachment 21565 [details] [review] [SIGNED-OFF] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No koha-qa errors. When creating a new framework it would be better to have Default on top, but one is way better than two :)
Created attachment 21596 [details] [review] [PASSED QA] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No koha-qa errors. When creating a new framework it would be better to have Default on top, but one is way better than two :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Agreed, one is better than two :) All tests and QA script pass.
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan!