Bug 10046 - Label budget should be fund on invoices page
Summary: Label budget should be fund on invoices page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 10065
  Show dependency treegraph
 
Reported: 2013-04-14 09:23 UTC by Katrin Fischer
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot (19.74 KB, image/png)
2013-04-14 09:23 UTC, Katrin Fischer
Details
Bug 10046: Standardize terms used in invoices (5.53 KB, patch)
2013-04-14 15:35 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10046: Standardize terms used in invoices (5.63 KB, patch)
2013-04-15 14:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10046: Standardize terms used in invoices (5.66 KB, patch)
2013-04-19 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-04-14 09:23:12 UTC
Created attachment 17415 [details]
screenshot

The label for funds is budget, which is wrong.

1) Create a new invoice and receive a few books.
2) Look at the invoice details after finishing receiving.
Comment 1 Katrin Fischer 2013-04-14 09:25:01 UTC
Also the form needs to be prettied a little bit as the layout of the fields and labels is not consistent with other forms.
Comment 2 Katrin Fischer 2013-04-14 15:35:05 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-04-15 14:01:42 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-04-19 12:25:30 UTC
QA comment:
Trivial patch. Fix some wrong terms.
Marked as Passed QA.
Comment 5 Jonathan Druart 2013-04-19 12:26:25 UTC
Created attachment 17540 [details] [review]
Bug 10046: Standardize terms used in invoices

Changes are:
budget > where actually fund is meant
branch > library
bookseller, supplier > vendor

To test:

1) Receive a shipment, check the little form where you
   enter your invoice number for correct use of terms.
2) Receive some orders and save finish receiving.
3) Search for your created invoice. Check filters and
   results table for correct use of terms.
4) Look at the details of your invoice, repeat check there.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jared Camins-Esakov 2013-04-21 13:37:30 UTC
This patch has been pushed to master and 3.12.x.
Comment 7 Chris Cormack 2013-04-27 05:38:22 UTC
Does not apply on 3.10.x please send new patch if one is needed