Created attachment 17415 [details] screenshot The label for funds is budget, which is wrong. 1) Create a new invoice and receive a few books. 2) Look at the invoice details after finishing receiving.
Also the form needs to be prettied a little bit as the layout of the fields and labels is not consistent with other forms.
Created attachment 17419 [details] [review] Bug 10046: Standardize terms used in invoices Changes are: budget > where actually fund is meant branch > library bookseller, supplier > vendor To test: 1) Receive a shipment, check the little form where you enter your invoice number for correct use of terms. 2) Receive some orders and save finish receiving. 3) Search for your created invoice. Check filters and results table for correct use of terms. 4) Look at the details of your invoice, repeat check there.
Created attachment 17458 [details] [review] [SIGNED-OFF] Bug 10046: Standardize terms used in invoices Changes are: budget > where actually fund is meant branch > library bookseller, supplier > vendor To test: 1) Receive a shipment, check the little form where you enter your invoice number for correct use of terms. 2) Receive some orders and save finish receiving. 3) Search for your created invoice. Check filters and results table for correct use of terms. 4) Look at the details of your invoice, repeat check there. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment: Trivial patch. Fix some wrong terms. Marked as Passed QA.
Created attachment 17540 [details] [review] Bug 10046: Standardize terms used in invoices Changes are: budget > where actually fund is meant branch > library bookseller, supplier > vendor To test: 1) Receive a shipment, check the little form where you enter your invoice number for correct use of terms. 2) Receive some orders and save finish receiving. 3) Search for your created invoice. Check filters and results table for correct use of terms. 4) Look at the details of your invoice, repeat check there. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master and 3.12.x.
Does not apply on 3.10.x please send new patch if one is needed