Bug 10065 - Style invoice edit form according to standard structure
Summary: Style invoice edit form according to standard structure
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL: /cgi-bin/koha/acqui/invoice.pl?invoic...
Keywords:
Depends on: 10046
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-16 13:08 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10065 - Style invoice edit form according to standard structure (5.76 KB, patch)
2013-04-16 13:49 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 10065 - Style invoice edit form according to standard structure (5.78 KB, patch)
2013-04-19 07:47 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 10065 - Style invoice edit form according to standard structure (5.84 KB, patch)
2013-04-19 12:40 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-04-16 13:08:05 UTC 
The layout of the invoice edit form does not match that of other forms in the staff client. The structure of the form should be corrected to match similar forms.
Comment 1 Owen Leonard 2013-04-16 13:49:34 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-19 07:47:48 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-04-19 12:40:10 UTC 
QA Comment:

Standardize the form on the invoice page.

I don't understand the indentation structure:
<ol>
<li><label>text</label>
[8spaces]<input/></li>
<ol>

I prefer:
<ol>
  <li>
    <label>text</label>
    <input/>
  <li>
</ol>

As long as we don't have coding guidelines for template structures, I cannot fail QA for a personal taste :)

So I mark it as passed qa.
Comment 4 Jonathan Druart 2013-04-19 12:40:48 UTC 
Created attachment 17543 [details] [review]
Bug 10065 - Style invoice edit form according to standard structure

The structure of the invoice edit form does not match that of similar
forms in the staff client. This patch alters it to be consistent.

To test you must also have the patch for Bug 10046 applied.

Go to Acquisitions -> Invoices and search for invoices. Click an invoice
to view/edit details. The form displaying fields for shipment date,
billing date, etc. should look correct and work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2013-04-21 13:47:32 UTC 
This patch has been pushed to master and 3.12.x.