When you use the 007 builder to view the existing values in the 007 tag, Koha is not pulling these existing values into the builder window. Instead, Koha appears to be using defaults. For example: 1. Open a record in the editor 2. The existing fixed field values in the 007 tag are: vd || || 3. Using the tag editor, open the 007 tag builder window and you will see that Koha is not dsiplaying the existing values. 4.If you click the OK button Koha enters the following values: vc aa ak The problem also exists in the 006 tag as well.
Still valid.
The bigger problem is on 007 for Electronic resource and Microform. The plugin can't handle existing values when positions 06,07,08 must to be worked together.
The issue is in the template file. Anything that is 9595 lines long has got to have something wrong with it.
Created attachment 53118 [details] [review] Bug 10148: Marc21 field 007 builder improper reload values The more correct solution is fix that template file. However, in the mean time, this works. TEST PLAN --------- 1) find a record 2) edit record 3) click value builder for 007 4) change everything to pipes as much as possible. (use Motion Picture to get all 00-22 values) 5) save -- should save just fine. 6) click the value builder again -- OOPS! Bad reload. 7) prove t/db_dependent/FrameworkPlugin.t -- NOISY 007 messages. 8) apply patch 9) click the value builder again -- good reload 10) prove t/db_dependent/FrameworkPlugin.t -- No noise related to 007. 11) run koha qa test tools.
I can't duplicate the problem for 006.
Created attachment 54075 [details] [review] Bug 10148: Marc21 field 007 builder improper reload values The more correct solution is fix that template file. However, in the mean time, this works. TEST PLAN --------- 1) find a record 2) edit record 3) click value builder for 007 4) change everything to pipes as much as possible. (use Motion Picture to get all 00-22 values) 5) save -- should save just fine. 6) click the value builder again -- OOPS! Bad reload. 7) prove t/db_dependent/FrameworkPlugin.t -- NOISY 007 messages. 8) apply patch 9) click the value builder again -- good reload 10) prove t/db_dependent/FrameworkPlugin.t -- No noise related to 007. 11) run koha qa test tools. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This is a bad bug in my eyes as it's easy to lose data this way. Patch fixes 007, we still need a fix for 006. I am splitting 006 out into a separate bug 17072 so this one can move on.
Created attachment 54103 [details] [review] [PASSED QA] Bug 10148: Marc21 field 007 builder improper reload values The more correct solution is fix that template file. However, in the mean time, this works. TEST PLAN --------- 1) find a record 2) edit record 3) click value builder for 007 4) change everything to pipes as much as possible. (use Motion Picture to get all 00-22 values) 5) save -- should save just fine. 6) click the value builder again -- OOPS! Bad reload. 7) prove t/db_dependent/FrameworkPlugin.t -- NOISY 007 messages. 8) apply patch 9) click the value builder again -- good reload 10) prove t/db_dependent/FrameworkPlugin.t -- No noise related to 007. 11) run koha qa test tools. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 16.11, thanks Mark!
Pushed in 16.05. Will be in 16.05.03.
Pushed to 3.22.x, will be in 3.22.10