Moved out from bug 10148: When you use the 006 builder to view the existing values in the 006 tag, Koha is not pulling these existing values into the builder window. Instead, Koha appears to be using defaults. For example: 1. Open a record in the editor 2. Switch from BKS to another material type. 3. Change as many settings as possible. 4. Close plugin. 5. Reopen plugin - notice your selections are not shown.
Created attachment 55095 [details] [review] Bug 17072 - 006 not filling in with existing values When you use the 006 builder to view the existing values in the 006 tag, Koha is not pulling these existing values into the builder window. Instead, Koha appears to be using defaults. To reproduce: 1. Open a record in the editor 2. Switch from BKS to another material type. 3. Change as many settings as possible. 4. Close plugin. 5. Reopen plugin - notice your selections are not shown. Trivial patch, heavilly inspired by Bug 9093. To test: 1. Apply patch 2. Ensure that issue described above is no longer reproductible
Created attachment 55198 [details] [review] [SIGNED-OFF]Bug 17072: 006 not filling in with existing values When you use the 006 builder to view the existing values in the 006 tag, Koha is not pulling these existing values into the builder window. Instead, Koha appears to be using defaults. To reproduce: 1. Open a record in the editor 2. Switch from BKS to another material type. 3. Change as many settings as possible. 4. Close plugin. 5. Reopen plugin - notice your selections are not shown. Trivial patch, heavilly inspired by Bug 9093. To test: 1. Apply patch 2. Ensure that issue described above is no longer reproductible Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Why don't you use the same mapping as from bug 9093? Would not it be worth putting that mapping in a centralized place?
(In reply to Jonathan Druart from comment #3) > Why don't you use the same mapping as from bug 9093? > Would not it be worth putting that mapping in a centralized place? I considered for a moment (albeit a very brief one) putting this code into some kind of subroutine which would handle both kinds of mappings for 006 and 008, but: - the mapping is pretty similar, but not identical (t, a, s) - AFAIK this could be reusable only in the MARC21 006 and 008 plugins - would have to add a pod section, unit tests (bleh) etc. for this sub - total amount of lines added will be probably 2x more then the now existing code in 008 and 006 combined - test plan and the bug description would require significantly more work than a simple copy & paste ;)
Created attachment 55303 [details] [review] Bug 17072: 006 not filling in with existing values When you use the 006 builder to view the existing values in the 006 tag, Koha is not pulling these existing values into the builder window. Instead, Koha appears to be using defaults. To reproduce: 1. Open a record in the editor 2. Switch from BKS to another material type. 3. Change as many settings as possible. 4. Close plugin. 5. Reopen plugin - notice your selections are not shown. Trivial patch, heavilly inspired by Bug 9093. To test: 1. Apply patch 2. Ensure that issue described above is no longer reproductible Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Jacek!
Pushed in 16.05. Will be in 16.05.04.
Pushed to 3.22.x, will be in 3.22.11