Created attachment 18028 [details] online access id See attached. It would be nice to be able to style the 'online access' text but the label doesn't have a unique ID.
Created attachment 18119 [details] [review] Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21).
Created attachment 18295 [details] [review] Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 18402 [details] [review] Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). Signed-off-by: Galen Charlton <gmc@esilibrary.com> html changes only, passes all tests Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I did not look, but I suppose a followup can be made for UNIMARC (in an other patch?) M. Saby
Pushed to master. Thanks, Owen! Setting status to assigned to Mathieu for a UNIMARC followup.
Comment on attachment 18402 [details] [review] Bug 10218 - In OPAC XSLT search results, add class to 'online access' Marking patch obsolete now that it has been pushed to master but with a UNIMARC follow-up to be expected.
Galen, I never really understood that : must or must not a followup for a patch already pushed in master be attached to a new bug ? From a discussion under an other bug, I believe it is a good practice? M. Saby
(In reply to comment #7) > Galen, I never really understood that : must or must not a followup for a > patch already pushed in master be attached to a new bug ? > From a discussion under an other bug, I believe it is a good practice? Well, the original bug description didn't specify that it was a MARC21-only bug. The perfect patch for this bug would have handled all of the MARC flavors that are currently supported, but as that didn't happen, I chose to leave the bug open. More broadly: unless a bug is truly specific to a particular MARC format, IMO we should aim for *complete* patches. However, this is a preference, not a requirement. If you prefer to open a new bug, you are free to do so. If you do that, please link it to this one via a dependency or a comment citing the new bug number.
In the past, some other bugs about XSLT or installation were MARC21 specific, without anouncing it. As you said, it is pretty annoying... I will add a followup on this bug, and change the status to Need Signoff. Mathieu
I pinged Magnus on IRC about this bug, as presumably the NORMARC stylesheets should be updated as well.
This patch has been pushed to 3.12.x, will be in 3.12.1. Leaving as ASSIGNED, waiting for the followups.
Sorry, my VM is broken, so the followups won't be there until some days... Mathieu.
Pushed to 3.10.x, will be in 3.10.7 Leaving as ASSIGNED.
Created attachment 18948 [details] [review] [PATCH] Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. M. Saby
Title changed as MARC support has been pushed, and UNIMARC patches are waiting.
Created attachment 20678 [details] [review] Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works exactly as described on results and detail. No koha-qa errors
Created attachment 20679 [details] [review] [SIGNED-OFF] Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works exactly as described on results and detail. No koha-qa errors
Created attachment 20861 [details] [review] [PASSED QA] Bug 10218: Add individual CSS classes for bibliographic information in OPAC (UNIMARC) Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works exactly as described on results and detail. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT only change. Tested in a UNIMARC install, HTML source code looks ok.
Comment on attachment 20861 [details] [review] [PASSED QA] Bug 10218: Add individual CSS classes for bibliographic information in OPAC (UNIMARC) Pushed to master. Thanks, Mathieu! Setting back to assigned; only NORMARC remains.
There is already a bug called "Bug 7490 - Add CSS classes/ids to OPAC and staff NORMARC XSLT views" - I'll use that when I get around to dealing with this issue. Thanks for remembering poor old NORMARC! :-)
This patch has been pushed to 3.12.x, will be in 3.12.6. Thanks Mathieu! Marked 'Pushed to stable' as there's a NORMARC-specific bug for the remaining NORMARC fix.
Pushed to 3.10.x, will be in 3.10.12
Same changes must be made to new bootstrap opac. Mathieu